#13 ability to add modal confirmation or nothing instead of launch from of process run ui. Rework options names

Author: clever-age-gtonon

docs/index.md

@@ -35,13 +35,13 @@ Now you can access UI Process via http://your-domain.com/process
 
 ### Launch process via UI
 From UI "Process List" menu entry you can run a process by clicking on "Rocket" action.
-You can manage this behaviour by setting some ui options on process configuration ui option.
+You can manage this behaviour by setting some ui option `ui_launch_mode`
 
-| Options                          | Values         | UI behaviour |
-|----------------------------------|----------------|:---------:|
-| input_context_launcher_form<br>run_confirmation_modal | false<br>false | Run process without any confirmation
-| input_context_launcher_form<br>run_confirmation_modal | true<br>false  | On click, open a form to set input and context execution
-| input_context_launcher_form<br>run_confirmation_modal | false<br>true  | On click, open confirmation model to confirm process execution
+|      Value      |                          UI behaviour                          |
+|:---------------:|:--------------------------------------------------------------:|
+| modal (default) | On click, open confirmation modal to confirm process execution | 
+|      form       |    On click, open a form to set input and context execution    |
+|      null       |              Run process without any confirmation              | 
 
 ### Launch process via http request
 You can launch a process via http post request

src/Controller/Admin/Process/LaunchAction.php

@@ -58,7 +58,7 @@ public function __invoke(
         if (null === $uiOptions) {
             throw new \InvalidArgumentException('Missing UI Options');
         }
-        if (false === $uiOptions['input_context_launcher_form']) {
+        if (null === $uiOptions['ui_launch_mode'] || 'modal' === $uiOptions['ui_launch_mode']) {
             $this->dispatch($processCode);
             $this->addFlash(
                 'success',

src/Manager/ProcessConfigurationsManager.php

@@ -24,7 +24,7 @@
  * @phpstan-type UiOptions array{
  *      'source': ?string,
  *      'target': ?string,
- *      'input_context_launcher_form': bool,
+ *      'ui_launch_mode': ?string,
  *      'run_confirmation_modal': bool,
  *      'entrypoint_type': string,
  *      'constraints': Constraint[],
@@ -78,8 +78,7 @@ private function resolveUiOptions(array $options): array
                     'source' => null,
                     'target' => null,
                     'entrypoint_type' => 'text',
-                    'input_context_launcher_form' => false,
-                    'run_confirmation_modal' => false,
+                    'ui_launch_mode' => 'modal',
                     'constraints' => [],
                     'run' => null,
                     'default' => function (OptionsResolver $defaultResolver) {
@@ -99,8 +98,7 @@ private function resolveUiOptions(array $options): array
             );
             $uiResolver->setAllowedValues('entrypoint_type', ['text', 'file']);
             $uiResolver->setNormalizer('constraints', fn (Options $options, array $values): array => (new ConstraintLoader())->buildConstraints($values));
-            $uiResolver->setAllowedTypes('input_context_launcher_form', ['bool']);
-            $uiResolver->setAllowedTypes('run_confirmation_modal', ['bool']);
+            $uiResolver->setAllowedValues('ui_launch_mode', ['modal', null, 'form']);
         });
         /**
          * @var array{'ui': UiOptions} $options

templates/admin/field/report.html.twig

@@ -2,7 +2,5 @@
 {# @var field \EasyCorp\Bundle\EasyAdminBundle\Dto\FieldDto #}
 {# @var entity \EasyCorp\Bundle\EasyAdminBundle\Dto\EntityDto #}
 <ul>
-    {% for key, item in field.value %}
-        <li class="list-group-item"><span class="badge badge-{{ log_css_class(key) }}">{{ key }}</span> : {{ item }}</li>
-    {% endfor %}
+  {{ field.value }}
 </ul>

templates/admin/process/list.html.twig

@@ -33,7 +33,7 @@
                     <td>{% if process.options.ui.source is defined %}{{ process.options.ui.source }}{% endif %}</td>
                     <td>{% if process.options.ui.target is defined %}{{ process.options.ui.target }}{% endif %}</td>
                     <td class="text-center">
-                        {% if (false == uiOptions.input_context_launcher_form and true == uiOptions.run_confirmation_modal) %}
+                        {% if ("modal" == uiOptions.ui_launch_mode) %}
                             <a class="px-1" data-toggle="tooltip" data-placement="top" title="{{ 'Launch'|trans }}" data-bs-toggle="modal" data-bs-target="#{{ process.code }}">
                                 <i class="fas fa-rocket"></i>
                             </a>