#12 Remove all phpstan ignoreErrors. Fix code.

Author: njoubert-cleverage

phpstan.neon

@@ -3,16 +3,3 @@ parameters:
     paths:
         - src
         - tests
-    ignoreErrors:
-        - '#type has no value type specified in iterable type#'
-        - '#has parameter .* with no value type specified in iterable type#'
-        - '#has no value type specified in iterable type array#'
-        - '#configureOptions\(\) has no return type specified.#'
-        - '#configure\(\) has no return type specified#'
-        - '#process\(\) has no return type specified#'
-        - '#should return Iterator but returns Traversable#'
-        - '#Negated boolean expression is always false#'
-    checkGenericClassInNonGenericObjectType: false
-    reportUnmatchedIgnoredErrors: false
-    inferPrivatePropertyTypeFromConstructor: true
-    treatPhpDocTypesAsCertain: false

src/Task/FileFetchTask.php

@@ -16,7 +16,6 @@
 use CleverAge\ProcessBundle\Model\AbstractConfigurableTask;
 use CleverAge\ProcessBundle\Model\IterableTaskInterface;
 use CleverAge\ProcessBundle\Model\ProcessState;
-use League\Flysystem\Filesystem;
 use League\Flysystem\FilesystemException;
 use League\Flysystem\FilesystemOperator;
 use Symfony\Component\DependencyInjection\ServiceLocator;
@@ -32,6 +31,9 @@ class FileFetchTask extends AbstractConfigurableTask implements IterableTaskInte
 
     protected FilesystemOperator $destinationFS;
 
+    /**
+     * @var array<int, string>
+     */
     protected array $matchingFiles = [];
 
     /**

src/Task/ListContentTask.php

@@ -26,6 +26,9 @@
  */
 class ListContentTask extends AbstractConfigurableTask implements IterableTaskInterface
 {
+    /**
+     * @var list<\League\Flysystem\StorageAttributes>|null
+     */
     protected ?array $fsContent = null;
 
     /**
@@ -76,6 +79,8 @@ public function next(ProcessState $state): bool
     }
 
     /**
+     * @return list<\League\Flysystem\StorageAttributes>
+     *
      * @throws FilesystemException
      */
     protected function getFilteredFilesystemContents(FilesystemOperator $filesystem, ?string $pattern = null): array