fix deprecations

Author: xaviermarchegay

src/Task/Database/DatabaseReaderTask.php

@@ -18,8 +18,7 @@
 use CleverAge\ProcessBundle\Model\IterableTaskInterface;
 use CleverAge\ProcessBundle\Model\ProcessState;
 use Doctrine\DBAL\Connection;
-use Doctrine\DBAL\Driver\PDOStatement;
-use Doctrine\DBAL\Driver\ResultStatement;
+use Doctrine\DBAL\Result;
 use Doctrine\Persistence\ManagerRegistry;
 use Psr\Log\LoggerInterface;
 use Psr\Log\LogLevel;
@@ -30,7 +29,7 @@
  */
 class DatabaseReaderTask extends AbstractConfigurableTask implements IterableTaskInterface, FinalizableTaskInterface
 {
-    protected ?PDOStatement $statement = null;
+    protected ?Result $statement = null;
 
     protected mixed $nextItem = null;
 
@@ -51,7 +50,7 @@ public function next(ProcessState $state): bool
             return false;
         }
 
-        $this->nextItem = $this->statement->fetch();
+        $this->nextItem = $this->statement->fetchAssociative();
 
         return (bool) $this->nextItem;
     }
@@ -68,7 +67,7 @@ public function execute(ProcessState $state): void
             $result = $this->nextItem;
             $this->nextItem = null;
         } else {
-            $result = $this->statement->fetch();
+            $result = $this->statement->fetchAssociative();
         }
 
         // Handle empty results
@@ -88,7 +87,7 @@ public function execute(ProcessState $state): void
             $i = 0;
             while ($result !== false && $i++ < $options['paginate']) {
                 $results[] = $result;
-                $result = $this->statement->fetch();
+                $result = $this->statement->fetchAssociative();
             }
             $state->setOutput($results);
         } else {
@@ -98,12 +97,10 @@ public function execute(ProcessState $state): void
 
     public function finalize(ProcessState $state): void
     {
-        if ($this->statement) {
-            $this->statement->closeCursor();
-        }
+        $this->statement?->free();
     }
 
-    protected function initializeStatement(ProcessState $state): ResultStatement
+    protected function initializeStatement(ProcessState $state): Result
     {
         $options = $this->getOptions($state);
         $connection = $this->getConnection($state);

src/Task/Database/DatabaseUpdaterTask.php

@@ -16,6 +16,7 @@
 use CleverAge\ProcessBundle\Model\AbstractConfigurableTask;
 use CleverAge\ProcessBundle\Model\ProcessState;
 use Doctrine\DBAL\Connection;
+use Doctrine\DBAL\Exception;
 use Doctrine\Persistence\ManagerRegistry;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
@@ -43,6 +44,7 @@ public function execute(ProcessState $state): void
 
     /**
      * @return integer The number of affected rows.
+     * @throws Exception
      */
     protected function initializeStatement(ProcessState $state): int
     {
@@ -58,7 +60,7 @@ protected function initializeStatement(ProcessState $state): int
             throw new UnexpectedValueException('Expecting an array of params');
         }
 
-        return $connection->executeUpdate($options['sql'], $params, $options['types']);
+        return $connection->executeStatement($options['sql'], $params, $options['types']);
     }
 
     protected function configureOptions(OptionsResolver $resolver): void

src/Task/EntityManager/AbstractDoctrineQueryTask.php

@@ -18,6 +18,7 @@
 use Psr\Log\LogLevel;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use UnexpectedValueException;
+use function is_array;
 
 /**
  * Easily extendable task to query entities in their repository
@@ -57,27 +58,23 @@ protected function configureOptions(OptionsResolver $resolver): void
         );
     }
 
-    /**
-     * @param int              $limit
-     * @param int              $offset
-     */
     protected function getQueryBuilder(
         EntityRepository $repository,
         array $criteria,
         array $orderBy,
-        $limit = null,
-        $offset = null
+        ?int $limit = null,
+        ?int $offset = null
     ): QueryBuilder {
         $qb = $repository->createQueryBuilder('e');
         foreach ($criteria as $field => $value) {
             if (preg_match('/[^a-zA-Z0-9]/', $field)) {
                 throw new UnexpectedValueException("Forbidden field name '{$field}'");
             }
-            $parameterName = uniqid('param', false);
+            $parameterName = uniqid('param', true);
             if ($value === null) {
                 $qb->andWhere("e.{$field} IS null");
             } else {
-                if (\is_array($value)) {
+                if (is_array($value)) {
                     $qb->andWhere("e.{$field} IN (:{$parameterName})");
                 } else {
                     $qb->andWhere("e.{$field} = :{$parameterName}");