refactor(clerk-js): Replace internal error module with shared/errors (#6841)

Author: nikosdouvlis

.changeset/mighty-frogs-brake.md

@@ -0,0 +1,2 @@
+---
+---

.prettierignore

@@ -20,5 +20,7 @@ package-lock.json
 pnpm-lock.yaml
 playground
 packages/backend/tests/**/*.js
+packages/clerk-js/src/core/resources/internal.ts
+packages/clerk-js/src/core/resources/index.ts
 /**/CHANGELOG.md
 renovate.json5

packages/clerk-js/src/core/__tests__/clerk.test.ts

@@ -1,3 +1,4 @@
+import { EmailLinkErrorCodeStatus } from '@clerk/shared/error';
 import type {
   ActiveSessionResource,
   PendingSessionResource,
@@ -13,7 +14,7 @@ import type { DevBrowser } from '../auth/devBrowser';
 import { Clerk } from '../clerk';
 import { eventBus, events } from '../events';
 import type { DisplayConfig, Organization } from '../resources/internal';
-import { BaseResource, Client, EmailLinkErrorCodeStatus, Environment, SignIn, SignUp } from '../resources/internal';
+import { BaseResource, Client, Environment, SignIn, SignUp } from '../resources/internal';
 import { mockJwt } from '../test/fixtures';
 
 const mockClientFetch = jest.fn();

packages/clerk-js/src/core/clerk.ts

@@ -1,7 +1,14 @@
 import { inBrowser as inClientSide, isValidBrowserOnline } from '@clerk/shared/browser';
 import { clerkEvents, createClerkEventBus } from '@clerk/shared/clerkEventBus';
 import { deprecated } from '@clerk/shared/deprecated';
-import { ClerkRuntimeError, EmailLinkErrorCodeStatus, is4xxError, isClerkAPIResponseError } from '@clerk/shared/error';
+import {
+  ClerkRuntimeError,
+  EmailLinkError,
+  EmailLinkErrorCodeStatus,
+  is4xxError,
+  isClerkAPIResponseError,
+  isClerkRuntimeError,
+} from '@clerk/shared/error';
 import { parsePublishableKey } from '@clerk/shared/keys';
 import { LocalStorageBroadcastChannel } from '@clerk/shared/localStorageBroadcastChannel';
 import { logger } from '@clerk/shared/logger';
@@ -149,15 +156,7 @@ import { createClientFromJwt } from './jwt-client';
 import { APIKeys } from './modules/apiKeys';
 import { Billing } from './modules/billing';
 import { createCheckoutInstance } from './modules/checkout/instance';
-import {
-  BaseResource,
-  Client,
-  EmailLinkError,
-  Environment,
-  isClerkRuntimeError,
-  Organization,
-  Waitlist,
-} from './resources/internal';
+import { BaseResource, Client, Environment, Organization, Waitlist } from './resources/internal';
 import { getTaskEndpoint, navigateIfTaskExists, warnMissingPendingTaskHandlers } from './sessionTasks';
 import { State } from './state';
 import { warnings } from './warnings';

packages/clerk-js/src/core/fraudProtection.spec.ts

@@ -1,8 +1,8 @@
+import { ClerkAPIResponseError } from '@clerk/shared/error';
 import { beforeEach, describe, expect, it, type Mock, vi } from 'vitest';
 
 import { FraudProtection } from './fraudProtection';
 import type { Clerk, Client } from './resources/internal';
-import { ClerkAPIResponseError } from './resources/internal';
 
 describe('FraudProtectionService', () => {
   let sut: FraudProtection;

packages/clerk-js/src/core/fraudProtection.ts

@@ -1,6 +1,8 @@
+import { ClerkRuntimeError, isClerkAPIResponseError } from '@clerk/shared/error';
+
 import { CaptchaChallenge } from '../utils/captcha/CaptchaChallenge';
 import type { Clerk } from './resources/internal';
-import { ClerkRuntimeError, Client, isClerkAPIResponseError } from './resources/internal';
+import { Client } from './resources/internal';
 
 export class FraudProtection {
   private static instance: FraudProtection;

packages/clerk-js/src/core/modules/apiKeys/index.ts

@@ -1,3 +1,4 @@
+import { ClerkRuntimeError } from '@clerk/shared/error';
 import type {
   ApiKeyJSON,
   APIKeyResource,
@@ -9,7 +10,7 @@ import type {
 
 import type { FapiRequestInit } from '@/core/fapiClient';
 
-import { APIKey, BaseResource, ClerkRuntimeError } from '../../resources/internal';
+import { APIKey, BaseResource } from '../../resources/internal';
 
 export class APIKeys implements APIKeysNamespace {
   /**

packages/clerk-js/src/core/resources/Base.ts

@@ -1,12 +1,13 @@
 import { isValidBrowserOnline } from '@clerk/shared/browser';
+import { ClerkAPIResponseError, ClerkRuntimeError } from '@clerk/shared/error';
 import { isProductionFromPublishableKey } from '@clerk/shared/keys';
 import type { ClerkAPIErrorJSON, ClerkResourceJSON, ClerkResourceReloadParams, DeletedObjectJSON } from '@clerk/types';
 
 import { clerkMissingFapiClientInResources } from '../errors';
 import type { FapiClient, FapiRequestInit, FapiResponse, FapiResponseJSON, HTTPMethod } from '../fapiClient';
 import { FraudProtection } from '../fraudProtection';
 import type { Clerk } from './internal';
-import { ClerkAPIResponseError, ClerkRuntimeError, Client } from './internal';
+import { Client } from './internal';
 
 export type BaseFetchOptions = ClerkResourceReloadParams & {
   forceUpdateClient?: boolean;

packages/clerk-js/src/core/resources/BillingCheckout.ts

@@ -1,3 +1,4 @@
+import { isClerkAPIResponseError } from '@clerk/shared/error';
 import { retry } from '@clerk/shared/retry';
 import type {
   BillingCheckoutJSON,
@@ -12,7 +13,7 @@ import { unixEpochToDate } from '@/utils/date';
 
 import { billingTotalsFromJSON } from '../../utils';
 import { BillingPayer } from './BillingPayer';
-import { BaseResource, BillingPaymentSource, BillingPlan, isClerkAPIResponseError } from './internal';
+import { BaseResource, BillingPaymentSource, BillingPlan } from './internal';
 
 export class BillingCheckout extends BaseResource implements BillingCheckoutResource {
   id!: string;