test(integration): fix session_exists tests to use separate tabs

- Use runInNewTab to properly test session_exists scenario
- First tab signs in, second tab attempts to sign in with same user
- This triggers the session_exists error that the code handles
- Without separate tabs, SignIn component would auto-redirect on mount

Author: brkalow

integration/tests/oauth-flows.test.ts

@@ -257,10 +257,14 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withLegalConsent] })(
       await u.page.waitForAppUrl('/protected');
     });
 
-    test('redirects when attempting OAuth sign in with existing session', async ({ page, context }) => {
-      const u = createTestUtils({ app, page, context });
-
-      // First, sign in the user via OAuth
+    test('redirects when attempting OAuth sign in with existing session in another tab', async ({
+      page,
+      context,
+      browser,
+    }) => {
+      const u = createTestUtils({ app, page, context, browser });
+
+      // Sign in on the first tab via OAuth
       await u.po.signIn.goTo();
       await u.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
       await u.page.getByText('Sign in to oauth-provider').waitFor();
@@ -270,12 +274,18 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withLegalConsent] })(
       await u.page.getByText('SignedIn').waitFor();
       await u.po.expect.toBeSignedIn();
 
-      // Now attempt to sign in again via OAuth while already signed in
-      await u.po.signIn.goTo();
-      await u.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
-
-      // Should redirect and remain signed in instead of showing an error
-      await u.po.expect.toBeSignedIn();
+      // Open a new tab and attempt to sign in again via OAuth with the same user
+      await u.tabs.runInNewTab(async u2 => {
+        await u2.po.signIn.goTo();
+        await u2.page.getByRole('button', { name: 'E2E OAuth Provider' }).click();
+        await u2.page.getByText('Sign in to oauth-provider').waitFor();
+        await u2.po.signIn.setIdentifier(fakeUser.email);
+        await u2.po.signIn.continue();
+        await u2.po.signIn.enterTestOtpCode();
+
+        // Should redirect and remain signed in instead of showing an error
+        await u2.po.expect.toBeSignedIn();
+      });
     });
   },
 );

integration/tests/sign-in-flow.test.ts

@@ -151,44 +151,53 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('sign in f
     await u.po.expect.toBeSignedIn();
   });
 
-  test('redirects when attempting to sign in with existing session', async ({ page, context }) => {
-    const u = createTestUtils({ app, page, context });
+  test('redirects when attempting to sign in with existing session in another tab', async ({
+    page,
+    context,
+    browser,
+  }) => {
+    const u = createTestUtils({ app, page, context, browser });
 
-    // First, sign in the user
+    // Sign in on the first tab
     await u.po.signIn.goTo();
     await u.po.signIn.setIdentifier(fakeUser.email);
     await u.po.signIn.continue();
     await u.po.signIn.setPassword(fakeUser.password);
     await u.po.signIn.continue();
     await u.po.expect.toBeSignedIn();
 
-    // Now attempt to go to sign-in page again while already signed in
-    await u.po.signIn.goTo();
+    // Open a new tab and attempt to sign in again with the same user
+    await u.tabs.runInNewTab(async u2 => {
+      await u2.po.signIn.goTo();
+      await u2.po.signIn.setIdentifier(fakeUser.email);
+      await u2.po.signIn.continue();
+      await u2.po.signIn.setPassword(fakeUser.password);
+      await u2.po.signIn.continue();
 
-    // User should be redirected and remain signed in instead of seeing an error
-    await u.po.expect.toBeSignedIn();
+      // Should redirect and be signed in without error
+      await u2.po.expect.toBeSignedIn();
+    });
   });
 
-  test('redirects when attempting to sign in again with instant password and existing session', async ({
+  test('redirects when attempting to sign in again with instant password in another tab', async ({
     page,
     context,
+    browser,
   }) => {
-    const u = createTestUtils({ app, page, context });
+    const u = createTestUtils({ app, page, context, browser });
 
-    // First, sign in the user
+    // Sign in on the first tab
     await u.po.signIn.goTo();
     await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
     await u.po.expect.toBeSignedIn();
 
-    // Clear the page to go back to sign-in
-    await u.page.goToRelative('/');
-    await u.po.expect.toBeSignedIn();
+    // Open a new tab and attempt to sign in again with instant password
+    await u.tabs.runInNewTab(async u2 => {
+      await u2.po.signIn.goTo();
+      await u2.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
 
-    // Attempt to sign in again with instant password
-    await u.po.signIn.goTo();
-    await u.po.signIn.signInWithEmailAndInstantPassword({ email: fakeUser.email, password: fakeUser.password });
-
-    // Should redirect and remain signed in without error
-    await u.po.expect.toBeSignedIn();
+      // Should redirect and remain signed in without error
+      await u2.po.expect.toBeSignedIn();
+    });
   });
 });