Skip to content

Commit 376b4e4

Browse files
committed
remove cross-site check
1 parent ffde23d commit 376b4e4

File tree

2 files changed

+31
-4
lines changed

2 files changed

+31
-4
lines changed

packages/backend/src/tokens/__tests__/request.test.ts

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,5 +1796,36 @@ describe('tokens.authenticateRequest(options)', () => {
17961796
signInUrl: 'https://primary.com/sign-in',
17971797
});
17981798
});
1799+
1800+
test('does not trigger handshake when referrer matches current origin despite sec-fetch-site cross-site (redirect chain)', async () => {
1801+
const request = mockRequestWithCookies(
1802+
{
1803+
host: 'primary.com',
1804+
referer: 'https://primary.com/some-page',
1805+
'sec-fetch-dest': 'document',
1806+
'sec-fetch-site': 'cross-site', // This can happen due to redirect chains through Clerk domains
1807+
},
1808+
{
1809+
__session: mockJwt,
1810+
__client_uat: '12345',
1811+
},
1812+
'https://primary.com/dashboard',
1813+
);
1814+
1815+
const requestState = await authenticateRequest(request, {
1816+
...mockOptions(),
1817+
publishableKey: PK_LIVE,
1818+
domain: 'primary.com',
1819+
isSatellite: false,
1820+
signInUrl: 'https://primary.com/sign-in',
1821+
});
1822+
1823+
// Should not trigger handshake because referrer origin matches current origin
1824+
expect(requestState).toBeSignedIn({
1825+
domain: 'primary.com',
1826+
isSatellite: false,
1827+
signInUrl: 'https://primary.com/sign-in',
1828+
});
1829+
});
17991830
});
18001831
});

packages/backend/src/tokens/authenticateContext.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,6 @@ class AuthenticateContext implements AuthenticateContext {
188188
}
189189

190190
try {
191-
if (this.getHeader(constants.Headers.SecFetchSite) === 'cross-site') {
192-
return true;
193-
}
194-
195191
const referrerOrigin = new URL(this.referrer).origin;
196192
return referrerOrigin !== this.clerkUrl.origin;
197193
} catch {

0 commit comments

Comments
 (0)