Refactor: Extract code in bin/phpdoc-md into class #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature: .phpdoc-md can return an object or an array
Collaborator
|
+1 This helps to resolve #8 |
Collaborator
|
However, I would recommend making the file operations optional (default enabled). That way you can feed data into and out of the command to test it without actually creating or accessing any files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing exciting here! This PR moves all of the code and logic from the
binscript into a class, and updates thebinscript to instantiate and call that class. Everything appears to be working and the example docs are generated with no changes.I did add one very minor feature: the .phpdoc-md config file can return an object or an array.
Thanks!