Skip to content

Commit d5b5558

Browse files
mokai87clarax
authored andcommitted
HBASE-24686 [LOG] Log improvement in Connection#close (apache#2219)
Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
1 parent 37928b1 commit d5b5558

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,10 @@ public void close() {
192192
if (closed) {
193193
return;
194194
}
195+
LOG.info("Connection has been closed by {}.", Thread.currentThread().getName());
196+
if(LOG.isDebugEnabled()){
197+
logCallStack(Thread.currentThread().getStackTrace());
198+
}
195199
IOUtils.closeQuietly(clusterStatusListener);
196200
IOUtils.closeQuietly(rpcClient);
197201
IOUtils.closeQuietly(registry);
@@ -202,6 +206,16 @@ public void close() {
202206
closed = true;
203207
}
204208

209+
private void logCallStack(StackTraceElement[] stackTraceElements) {
210+
StringBuilder stackBuilder = new StringBuilder("Call stack:");
211+
for (StackTraceElement element : stackTraceElements) {
212+
stackBuilder.append("\n at ");
213+
stackBuilder.append(element);
214+
}
215+
stackBuilder.append("\n");
216+
LOG.debug(stackBuilder.toString());
217+
}
218+
205219
@Override
206220
public boolean isClosed() {
207221
return closed;

0 commit comments

Comments
 (0)