Skip to content

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Jul 5, 2019

If the parent repo has version tags (as cisagov/skeleton-packer does, for example) then those tags will be carried over into the child repo. We don't want that, and we want our child repo to start with no tags, so let's delete the local tags.

If the parent repo has version tags (as skeleton-packer does, for
example) then those tags will be carried over into the child repo.  We
don't want that, and we want our child repo to start with no tags, so
let's delete the local tags.
@jsf9k jsf9k requested review from KyleEvers, dav3r, felddy and mcdonnnj July 5, 2019 21:00
@jsf9k jsf9k self-assigned this Jul 5, 2019
@jsf9k jsf9k requested a review from a team July 5, 2019 21:08
Copy link
Contributor

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting some serious déjà vu here. Didn't I approve this already?

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart thinking! 👍

@jsf9k jsf9k merged commit 242877b into develop Jul 8, 2019
@jsf9k jsf9k deleted the improvement/delete_existing_tags branch July 8, 2019 12:20
dv4harr10 added a commit that referenced this pull request Mar 4, 2024
add back whitespace to reflect what the user
should expect to see in terminal output.
jsf9k pushed a commit that referenced this pull request Mar 7, 2024
add back whitespace to reflect what the user
should expect to see in terminal output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants