From 6463fa0e1af816992b5d5fa62dca75d1f1540f0d Mon Sep 17 00:00:00 2001 From: Mercy Bickell Date: Tue, 13 Jun 2023 16:05:27 -0700 Subject: [PATCH 1/3] Fix: add backgroundColor type on CartesianScaleOptions --- src/types/index.d.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/types/index.d.ts b/src/types/index.d.ts index 65e1213dcd7..ae2dd840c1f 100644 --- a/src/types/index.d.ts +++ b/src/types/index.d.ts @@ -3150,6 +3150,11 @@ export interface CartesianScaleOptions extends CoreScaleOptions { */ bounds: 'ticks' | 'data'; + /** + * Background color of the scale area. + */ + backgroundColor: Color; + /** * Position of the axis. */ From d914f7ff3640d3269f83915c4955c479a732490e Mon Sep 17 00:00:00 2001 From: Mercy Bickell Date: Wed, 14 Jun 2023 09:18:15 -0700 Subject: [PATCH 2/3] Add instead on CoreScaleOptions --- src/types/index.d.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/types/index.d.ts b/src/types/index.d.ts index ae2dd840c1f..4ef93f8cbe8 100644 --- a/src/types/index.d.ts +++ b/src/types/index.d.ts @@ -1166,6 +1166,10 @@ export interface CoreScaleOptions { * Align pixel values to device pixels */ alignToPixels: boolean; + /** + * Background color of the scale area. + */ + backgroundColor: Color; /** * Reverse the scale. * @default false @@ -3150,11 +3154,6 @@ export interface CartesianScaleOptions extends CoreScaleOptions { */ bounds: 'ticks' | 'data'; - /** - * Background color of the scale area. - */ - backgroundColor: Color; - /** * Position of the axis. */ From 32c226ee023e85397fbcdb9d3846382d0dcc9fa1 Mon Sep 17 00:00:00 2001 From: Mercy Bickell Date: Tue, 25 Jul 2023 14:17:14 -0600 Subject: [PATCH 3/3] Remove redundant backgroundColor from RadialLinearScaleOptions --- src/types/index.d.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/types/index.d.ts b/src/types/index.d.ts index 4ef93f8cbe8..19ddbe7f467 100644 --- a/src/types/index.d.ts +++ b/src/types/index.d.ts @@ -3447,8 +3447,6 @@ export type RadialTickOptions = TickOptions & { } export type RadialLinearScaleOptions = CoreScaleOptions & { - backgroundColor: Color; - animate: boolean; startAngle: number;