From 9c0ba64020374a70d0d5bb4a19c9ff2c359aba5f Mon Sep 17 00:00:00 2001 From: Jacco van den Berg Date: Fri, 19 May 2023 22:25:43 +0200 Subject: [PATCH 1/2] Update slack link --- README.md | 2 +- docs/.vuepress/config.ts | 2 +- docs/developers/contributing.md | 4 ++-- docs/getting-started/usage.md | 2 +- docs/index.md | 4 ++-- docs/migration/v3-migration.md | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index ed66714386f..73a5d73df04 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ GitHub Workflow Status Coverage Awesome - Slack + Slack

## Documentation diff --git a/docs/.vuepress/config.ts b/docs/.vuepress/config.ts index d1f7591fbfc..cc0921fe8f0 100644 --- a/docs/.vuepress/config.ts +++ b/docs/.vuepress/config.ts @@ -130,7 +130,7 @@ export default defineConfig({ ariaLabel: 'Community Menu', items: [ { text: 'Awesome', link: 'https://github.com/chartjs/awesome' }, - { text: 'Slack', link: 'https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw' }, + { text: 'Slack', link: 'https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg' }, { text: 'Stack Overflow', link: 'https://stackoverflow.com/questions/tagged/chart.js' } ] } diff --git a/docs/developers/contributing.md b/docs/developers/contributing.md index 1310eda4144..02bc62e11ac 100644 --- a/docs/developers/contributing.md +++ b/docs/developers/contributing.md @@ -2,7 +2,7 @@ New contributions to the library are welcome, but we ask that you please follow these guidelines: -- Before opening a PR for major additions or changes, please discuss the expected API and/or implementation by [filing an issue](https://github.com/chartjs/Chart.js/issues) or asking about it in the [Chart.js Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw) #dev channel. This will save you development time by getting feedback upfront and make reviews faster by giving the maintainers more context and details. +- Before opening a PR for major additions or changes, please discuss the expected API and/or implementation by [filing an issue](https://github.com/chartjs/Chart.js/issues) or asking about it in the [Chart.js Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg) #dev channel. This will save you development time by getting feedback upfront and make reviews faster by giving the maintainers more context and details. - Consider whether your changes are useful for all users, or if creating a Chart.js [plugin](plugins.md) would be more appropriate. - Check that your code will pass tests and `eslint` code standards. `pnpm test` will run both the linter and tests for you. - Add unit tests and document new functionality (in the `test/` and `docs/` directories respectively). @@ -11,7 +11,7 @@ New contributions to the library are welcome, but we ask that you please follow ## Joining the project -Active committers and contributors are invited to introduce themselves and request commit access to this project. We have a very active Slack community that you can join [here](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw). If you think you can help, we'd love to have you! +Active committers and contributors are invited to introduce themselves and request commit access to this project. We have a very active Slack community that you can join [here](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg). If you think you can help, we'd love to have you! ## Building and Testing diff --git a/docs/getting-started/usage.md b/docs/getting-started/usage.md index 94e186d66a9..b0133326d55 100644 --- a/docs/getting-started/usage.md +++ b/docs/getting-started/usage.md @@ -586,6 +586,6 @@ By importing and registering only select components, we’ve removed more than 5 Now you’re familiar with all major concepts of Chart.js: chart types and elements, datasets, customization, plugins, components, and tree-shaking. -Feel free to review many [examples of charts](../samples/information.html) in the documentation and check the [awesome list](https://github.com/chartjs/awesome) of Chart.js plugins and additional chart types as well as [framework integrations](https://github.com/chartjs/awesome#integrations) (e.g., React, Vue, Svelte, etc.). Also, don’t hesitate to join [Chart.js Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw) and follow [Chart.js on Twitter](https://twitter.com/chartjs). +Feel free to review many [examples of charts](../samples/information.html) in the documentation and check the [awesome list](https://github.com/chartjs/awesome) of Chart.js plugins and additional chart types as well as [framework integrations](https://github.com/chartjs/awesome#integrations) (e.g., React, Vue, Svelte, etc.). Also, don’t hesitate to join [Chart.js Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg) and follow [Chart.js on Twitter](https://twitter.com/chartjs). Have fun and good luck building with Chart.js! \ No newline at end of file diff --git a/docs/index.md b/docs/index.md index b280c9a59e5..371b0e56ff7 100644 --- a/docs/index.md +++ b/docs/index.md @@ -4,7 +4,7 @@ Welcome to Chart.js! * **[Get started with Chart.js](./getting-started/) — best if you're new to Chart.js** * Migrate from [Chart.js v3](./migration/v4-migration.html) or [Chart.js v2](./migration/v3-migration.html) -* Join the community on [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw) and [Twitter](https://twitter.com/chartjs) +* Join the community on [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg) and [Twitter](https://twitter.com/chartjs) * Post a question tagged with `chart.js` on [Stack Overflow](https://stackoverflow.com/questions/tagged/chart.js) * [Contribute to Chart.js](./developers/contributing.html) @@ -30,7 +30,7 @@ Chart.js comes with built-in TypeScript typings and is compatible with all popul ### Developer experience -Chart.js has very thorough documentation (yes, you're reading it), [API reference](./api/), and [examples](./samples/information.html). Maintainers and community members eagerly engage in conversations on [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw), [GitHub Discussions](https://github.com/chartjs/Chart.js/discussions), and [Stack Overflow](https://stackoverflow.com/questions/tagged/chart.js) where more than 11,000 questions are tagged with `chart.js`. +Chart.js has very thorough documentation (yes, you're reading it), [API reference](./api/), and [examples](./samples/information.html). Maintainers and community members eagerly engage in conversations on [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg), [GitHub Discussions](https://github.com/chartjs/Chart.js/discussions), and [Stack Overflow](https://stackoverflow.com/questions/tagged/chart.js) where more than 11,000 questions are tagged with `chart.js`. ### Canvas rendering diff --git a/docs/migration/v3-migration.md b/docs/migration/v3-migration.md index a456e3fe506..075171f2c59 100644 --- a/docs/migration/v3-migration.md +++ b/docs/migration/v3-migration.md @@ -249,7 +249,7 @@ Animation system was completely rewritten in Chart.js v3. Each property can now ## Developer migration -While the end-user migration for Chart.js 3 is fairly straight-forward, the developer migration can be more complicated. Please reach out for help in the #dev [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1lo81skkk-AZk6ollhOdrjt9GzPeOsLw) channel if tips on migrating would be helpful. +While the end-user migration for Chart.js 3 is fairly straight-forward, the developer migration can be more complicated. Please reach out for help in the #dev [Slack](https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg) channel if tips on migrating would be helpful. Some of the biggest things that have changed: From f3d55e9f3d16cc79b8afd56e3de324376da7401d Mon Sep 17 00:00:00 2001 From: Jacco van den Berg Date: Sat, 20 May 2023 00:54:15 +0200 Subject: [PATCH 2/2] Fix build --- docs/.vuepress/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/.vuepress/config.ts b/docs/.vuepress/config.ts index cc0921fe8f0..1ed27444116 100644 --- a/docs/.vuepress/config.ts +++ b/docs/.vuepress/config.ts @@ -130,7 +130,7 @@ export default defineConfig({ ariaLabel: 'Community Menu', items: [ { text: 'Awesome', link: 'https://github.com/chartjs/awesome' }, - { text: 'Slack', link: 'https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg' }, + // { text: 'Slack', link: 'https://join.slack.com/t/chartjs/shared_invite/zt-1vdtibucn-tqbjBY~YAm_sP8iNFpU7Gg' }, Don't show slack link since vuepress can't handle the `~` symbol { text: 'Stack Overflow', link: 'https://stackoverflow.com/questions/tagged/chart.js' } ] }