Course catalog: Fix option to hide the link to course catalog in the menu not to block access to the catalog -refs BT20652

Author: NicoDucou

main/auth/courses.php

@@ -12,9 +12,7 @@
 // Section for the tabs.
 $this_section = SECTION_CATALOG;
 
-if ('true' !== api_get_setting('course_catalog_published') ||
-    ('true' === api_get_setting('course_catalog_published') && api_get_configuration_value('catalog_hide_public_link'))
-) {
+if ('true' !== api_get_setting('course_catalog_published')) {
     // Access rights: anonymous users can't do anything useful here.
     api_block_anonymous_users();
 }