Script: Cron: optimization of script to avoid flush for each userupdate and also set only one flush for all user when desactivating users - refs BT#20351

Author: NicoDucou

tests/scripts/synchronize_user_base_from_csv.php

@@ -208,7 +208,7 @@
                 }
 
                 $user->setCreator($creator);
-                $userRepository->updateUser($user, true);
+                $userRepository->updateUser($user, false);
 
                 foreach ($CSVuser as $fieldName => $fieldValue) {
                     if (strpos($fieldName, EXTRA_KEY) === 0) {
@@ -296,14 +296,6 @@
                     $trackEDefault->setDefaultValue((string) $user->getId());
                     $entityManager->persist($trackEDefault);
 
-                    try {
-                        $entityManager->flush();
-                    } catch (OptimisticLockException $e) {
-                        error_log("Error processing user " . $e->getMessage());
-                        echo "Trace: " . $e->getTraceAsString() . "\n";
-                        continue;
-                    }
-
                     if ($debug) {
                         echo 'Disabled user ' . $usernameToDisable . "\n";
                     }