Skip to content

Commit a22589a

Browse files
committed
Security - Fix XSS attack vector in user profile - reported by Javier Bloem
1 parent dd9bcd6 commit a22589a

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

main/auth/profile.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ function show_icon_edit(element_html) {
143143
}
144144
$form->applyFilter(array('lastname', 'firstname'), 'stripslashes');
145145
$form->applyFilter(array('lastname', 'firstname'), 'trim');
146+
$form->applyFilter(array('lastname', 'firstname'), 'html_filter');
146147
$form->addRule('lastname' , get_lang('ThisFieldIsRequired'), 'required');
147148
$form->addRule('firstname', get_lang('ThisFieldIsRequired'), 'required');
148149

@@ -165,6 +166,7 @@ function show_icon_edit(element_html) {
165166
}
166167
$form->applyFilter('official_code', 'stripslashes');
167168
$form->applyFilter('official_code', 'trim');
169+
$form->applyFilter('official_code', 'html_filter');
168170
if (api_get_setting('registration', 'officialcode') == 'true' && api_get_setting('profile', 'officialcode') == 'true') {
169171
$form->addRule('official_code', get_lang('ThisFieldIsRequired'), 'required');
170172
}
@@ -202,6 +204,7 @@ function show_icon_edit(element_html) {
202204
}
203205
$form->applyFilter('phone', 'stripslashes');
204206
$form->applyFilter('phone', 'trim');
207+
$form->applyFilter('phone', 'html_filter');
205208
/*if (api_get_setting('registration', 'phone') == 'true') {
206209
$form->addRule('phone', get_lang('ThisFieldIsRequired'), 'required');
207210
}

main/inc/lib/usermanager.lib.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4323,6 +4323,7 @@ static function set_extra_fields_in_form($form, $extra_data, $form_name, $admin_
43234323
$form->addElement('text', 'extra_'.$field_details[1], $field_details[3], array('size' => 40));
43244324
$form->applyFilter('extra_'.$field_details[1], 'stripslashes');
43254325
$form->applyFilter('extra_'.$field_details[1], 'trim');
4326+
$form->applyFilter('extra_'.$field_details[1], 'html_filter');
43264327

43274328
if (!$admin_permissions) {
43284329
if ($field_details[7] == 0)

0 commit comments

Comments
 (0)