Skip to content

Commit 40dd044

Browse files
committed
Minor - fix php notices, warnings
1 parent c6b8f85 commit 40dd044

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

main/lp/learnpathItem.class.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1920,7 +1920,11 @@ public function fixAbusiveTime($time)
19201920
}
19211921
}*/
19221922
// PL --- Porcentaje lección (tiempo leccion / tiempo total curso)
1923-
$pl = $timeLp / $timeTotalCourse;
1923+
$pl = 0;
1924+
if (!empty($timeTotalCourse)) {
1925+
$pl = $timeLp / $timeTotalCourse;
1926+
}
1927+
19241928
/*
19251929
* TL: Tiempo que pone en una lección
19261930
* TT : tiempo total que pone Teresa (suma tiempos lecciones curso)

main/lp/lp_view.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,10 @@
576576
}
577577

578578
// PL --- Porcentaje lección (tiempo leccion / tiempo total curso)
579-
$pl = $timeLp / $timeTotalCourse;
579+
$pl = 0;
580+
if (!empty($timeTotalCourse)) {
581+
$pl = $timeLp / $timeTotalCourse;
582+
}
580583

581584
/*
582585
* TL: Tiempo que pone en una lección

src/Chamilo/CourseBundle/Component/CourseCopy/CourseRestorer.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2874,7 +2874,7 @@ public function restore_learnpaths($session_id = 0, $respect_base_content = fals
28742874
// Updating prerequisites
28752875
foreach ($old_prerequisite as $key => $my_old_prerequisite) {
28762876
if ($my_old_prerequisite != '') {
2877-
$sql = "UPDATE ".$table_item." SET prerequisite = '".$my_old_prerequisite."'
2877+
$sql = "UPDATE $table_item SET prerequisite = '".$my_old_prerequisite."'
28782878
WHERE c_id = ".$this->destination_course_id." AND id = '".$key."' ";
28792879
Database::query($sql);
28802880
}
@@ -2883,7 +2883,7 @@ public function restore_learnpaths($session_id = 0, $respect_base_content = fals
28832883
// Updating refs
28842884
foreach ($old_refs as $key => $my_old_ref) {
28852885
if ($my_old_ref != '') {
2886-
$sql = "UPDATE ".$table_item." SET ref = '".$my_old_ref."'
2886+
$sql = "UPDATE $table_item SET ref = '".$my_old_ref."'
28872887
WHERE c_id = ".$this->destination_course_id." AND id = '".$key."' ";
28882888
Database::query($sql);
28892889
}
@@ -2892,10 +2892,10 @@ public function restore_learnpaths($session_id = 0, $respect_base_content = fals
28922892
foreach ($parent_item_ids as $new_item_id => $parent_item_old_id) {
28932893
$parent_new_id = 0;
28942894
if ($parent_item_old_id != 0) {
2895-
$parent_new_id = $new_item_ids[$parent_item_old_id];
2895+
$parent_new_id = isset($new_item_ids[$parent_item_old_id]) ? $new_item_ids[$parent_item_old_id] : 0;
28962896
}
2897-
$sql = "UPDATE ".$table_item." SET parent_item_id = '".$parent_new_id."'
2898-
WHERE c_id = ".$this->destination_course_id." AND id = '".$new_item_id."'";
2897+
$sql = "UPDATE $table_item SET parent_item_id = '$parent_new_id'
2898+
WHERE c_id = ".$this->destination_course_id." AND id = $new_item_id";
28992899
Database::query($sql);
29002900
}
29012901

@@ -2904,17 +2904,17 @@ public function restore_learnpaths($session_id = 0, $respect_base_content = fals
29042904
if ($previous_item_old_id != 0) {
29052905
$previous_new_id = isset($new_item_ids[$previous_item_old_id]) ? $new_item_ids[$previous_item_old_id] : '';
29062906
}
2907-
$sql = "UPDATE ".$table_item." SET previous_item_id = '".$previous_new_id."'
2907+
$sql = "UPDATE $table_item SET previous_item_id = $previous_new_id
29082908
WHERE c_id = ".$this->destination_course_id." AND id = '".$new_item_id."'";
29092909
Database::query($sql);
29102910
}
29112911

29122912
foreach ($next_item_ids as $new_item_id => $next_item_old_id) {
29132913
$next_new_id = 0;
29142914
if ($next_item_old_id != 0) {
2915-
$next_new_id = $new_item_ids[$next_item_old_id];
2915+
$next_new_id = isset($new_item_ids[$next_item_old_id]) ? $new_item_ids[$next_item_old_id] : 0;
29162916
}
2917-
$sql = "UPDATE ".$table_item." SET next_item_id = '".$next_new_id."'
2917+
$sql = "UPDATE $table_item SET next_item_id = $next_new_id
29182918
WHERE c_id = ".$this->destination_course_id." AND id = '".$new_item_id."'";
29192919
Database::query($sql);
29202920
}
@@ -2924,8 +2924,8 @@ public function restore_learnpaths($session_id = 0, $respect_base_content = fals
29242924
if ($prerequisite_old_id != 0) {
29252925
$prerequisite_new_id = $new_item_ids[$prerequisite_old_id];
29262926
}
2927-
$sql = "UPDATE ".$table_item." SET prerequisite = '".$prerequisite_new_id."'
2928-
WHERE c_id = ".$this->destination_course_id." AND id = '".$new_item_id."'";
2927+
$sql = "UPDATE $table_item SET prerequisite = $prerequisite_new_id
2928+
WHERE c_id = ".$this->destination_course_id." AND id = $new_item_id";
29292929
Database::query($sql);
29302930
}
29312931
$this->course->resources[RESOURCE_LEARNPATH][$id]->destination_id = $new_lp_id;

0 commit comments

Comments
 (0)