Attendance: Fix escaping of language var in JS context preventing comments to be added in attendance in courses in French - refs BT#22344

ywarnier · ywarnier · commit 3608709731f7 · 2025-04-17T12:25:13.000+02:00
diff --git a/main/attendance/attendance_comment.inc.php b/main/attendance/attendance_comment.inc.php
@@ -24,7 +24,7 @@
         $("#comment-popup-save").on("click", function() {
             var comment = $("#txt-comment").val();
             if (comment == '') {
-                alert('<?php echo get_lang('ProvideACommentFirst'); ?>');
+                alert('<?php echo addslashes(get_lang('ProvideACommentFirst')); ?>');
                 return false;
             }
             var selected = $("#comment-selected").val();
diff --git a/main/attendance/attendance_signature.inc.php b/main/attendance/attendance_signature.inc.php
@@ -63,7 +63,7 @@
 
         $("#sign_popup_save").on("click", function() {
             if (signaturePad.isEmpty()) {
-                alert('<?php echo get_lang('ProvideASignatureFirst'); ?>');
+                alert('<?php echo addslashes(get_lang('ProvideASignatureFirst')); ?>');
                 return false;
             }
             var selected = $("#sign-selected").val();

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`$("#comment-popup-save").on("click", function() {`
`25`	`25`	`var comment = $("#txt-comment").val();`
`26`	`26`	`if (comment == '') {`
`27`		`- alert('<?php echo get_lang('ProvideACommentFirst'); ?>');`
	`27`	`+ alert('<?php echo addslashes(get_lang('ProvideACommentFirst')); ?>');`
`28`	`28`	`return false;`
`29`	`29`	`}`
`30`	`30`	`var selected = $("#comment-selected").val();`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@`
`63`	`63`
`64`	`64`	`$("#sign_popup_save").on("click", function() {`
`65`	`65`	`if (signaturePad.isEmpty()) {`
`66`		`- alert('<?php echo get_lang('ProvideASignatureFirst'); ?>');`
	`66`	`+ alert('<?php echo addslashes(get_lang('ProvideASignatureFirst')); ?>');`
`67`	`67`	`return false;`
`68`	`68`	`}`
`69`	`69`	`var selected = $("#sign-selected").val();`