chore(dart): update to beta.17, code: ngFor # to let

chalin · chalin · commit 8db6aecea8ac · 2016-04-30T05:20:00.000-07:00
Changed `ngFor=“#…”` to `ngFor=“let…` in code. All are .dart files except for `app_component.html` which also has changes for: - `<inpuf var-foo…`> to `<input ref-foo…>` - `#docregion` tag name updates from var-foo to ref-foo. - Other misc updates to minimize diffs with TS version of file (though I ignored whitespace differences). Note that guide/pipes was not updated; it will be rolled back to beta.15 in PR angular#1220.
diff --git a/public/docs/_examples/architecture/dart/pubspec.yaml b/public/docs/_examples/architecture/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/attribute-directives/dart/pubspec.yaml b/public/docs/_examples/attribute-directives/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component.dart b/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component.dart
@@ -7,7 +7,7 @@ import 'hero_service.dart';
 @Component(
     selector: 'hero-list',
     template: '''
-      <div *ngFor="#hero of heroes">
+      <div *ngFor="let hero of heroes">
         {{hero.id}} - {{hero.name}}
         ({{hero.isSecret ? 'secret' : 'public'}})
       </div>''')
diff --git a/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component_1.dart b/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component_1.dart
@@ -7,7 +7,7 @@ import 'mock_heroes.dart';
 @Component(
     selector: 'hero-list',
     template: '''
-      <div *ngFor="#hero of heroes">
+      <div *ngFor="let hero of heroes">
         {{hero.id}} - {{hero.name}}
       </div>''')
 class HeroListComponent {
diff --git a/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component_2.dart b/public/docs/_examples/dependency-injection/dart/lib/heroes/hero_list_component_2.dart
@@ -7,7 +7,7 @@ import 'hero_service.dart';
 @Component(
     selector: 'hero-list',
     template: '''
-      <div *ngFor="#hero of heroes">
+      <div *ngFor="let hero of heroes">
         {{hero.id}} - {{hero.name}}
       </div>''')
 class HeroListComponent {
diff --git a/public/docs/_examples/dependency-injection/dart/pubspec.yaml b/public/docs/_examples/dependency-injection/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/displaying-data/dart/lib/app_component.dart b/public/docs/_examples/displaying-data/dart/lib/app_component.dart
@@ -17,7 +17,7 @@ final List<Hero> _heroes = [
 <h2>My favorite hero is: {{myHero.name}}</h2>
 <p>Heroes:</p>
 <ul>
-  <li *ngFor="#hero of heroes">
+  <li *ngFor="let hero of heroes">
     {{ hero.name }}
   </li>
 </ul>
diff --git a/public/docs/_examples/displaying-data/dart/lib/app_component_2.dart b/public/docs/_examples/displaying-data/dart/lib/app_component_2.dart
@@ -19,7 +19,7 @@ const List<String> _heroes = const [
 <p>Heroes:</p>
 <ul>
 // #docregion li-repeater
-  <li *ngFor="#hero of heroes">
+  <li *ngFor="let hero of heroes">
     {{ hero }}
   </li>
 // #enddocregion li-repeater
diff --git a/public/docs/_examples/displaying-data/dart/lib/app_component_3.dart b/public/docs/_examples/displaying-data/dart/lib/app_component_3.dart
@@ -19,7 +19,7 @@ final List<Hero> _heroes = [
 <h2>My favorite hero is: {{myHero.name}}</h2>
 <p>Heroes:</p>
 <ul>
-  <li *ngFor="#hero of heroes">
+  <li *ngFor="let hero of heroes">
     {{ hero.name }}
   </li>
 </ul>'''
diff --git a/public/docs/_examples/displaying-data/dart/pubspec.yaml b/public/docs/_examples/displaying-data/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/forms/dart/pubspec.yaml b/public/docs/_examples/forms/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/hierarchical-dependency-injection/dart/lib/heroes_list_component.dart b/public/docs/_examples/hierarchical-dependency-injection/dart/lib/heroes_list_component.dart
@@ -12,7 +12,7 @@ import 'heroes_service.dart';
     template: '''
   <div>
       <ul>
-        <li *ngFor="#editItem of heroes">
+        <li *ngFor="let editItem of heroes">
           <hero-card
             [hidden]="editItem.editing"
             [hero]="editItem.item">
diff --git a/public/docs/_examples/hierarchical-dependency-injection/dart/pubspec.yaml b/public/docs/_examples/hierarchical-dependency-injection/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/after_content_parent.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/after_content_parent.dart
@@ -76,7 +76,7 @@ class AfterContentComponent
       </after-content>
 
       <h4>-- Lifecycle Hook Log --</h4>
-      <div *ngFor="#msg of hookLog">{{msg}}</div>
+      <div *ngFor="let msg of hookLog">{{msg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/after_view_component.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/after_view_component.dart
@@ -18,7 +18,7 @@ import 'logger_service.dart';
       </div>
 
       <h4>-- Lifecycle Hook Log --</h4>
-      <div *ngFor="#msg of hookLog">{{msg}}</div>
+      <div *ngFor="let msg of hookLog">{{msg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/counter_component.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/counter_component.dart
@@ -11,7 +11,7 @@ import 'spy_directive.dart';
       Counter = {{counter}}
 
       <h5>-- Counter Change Log --</h5>
-      <div *ngFor="#chg of changeLog" mySpy>{{chg}}</div>
+      <div *ngFor="let chg of changeLog" mySpy>{{chg}}</div>
     </div>
     ''',
     styles: const [
@@ -49,7 +49,7 @@ class MyCounter implements OnChanges {
       <my-counter [counter]="value"></my-counter>
 
       <h4>-- Spy Lifecycle Hook Log --</h4>
-      <div *ngFor="#msg of spyLog">{{msg}}</div>
+      <div *ngFor="let msg of spyLog">{{msg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/on_changes_component.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/on_changes_component.dart
@@ -17,7 +17,7 @@ class Hero {
       <p>{{hero.name}} can {{power}}</p>
 
       <h4>-- Change Log --</h4>
-      <div *ngFor="#chg of changeLog">{{chg}}</div>
+      <div *ngFor="let chg of changeLog">{{chg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/peek_a_boo_parent_component.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/peek_a_boo_parent_component.dart
@@ -19,7 +19,7 @@ import 'peek_a_boo_component.dart';
       </peek-a-boo>
 
       <h4>-- Lifecycle Hook Log --</h4>
-      <div *ngFor="#msg of hookLog">{{msg}}</div>
+      <div *ngFor="let msg of hookLog">{{msg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/lib/spy_component.dart b/public/docs/_examples/lifecycle-hooks/dart/lib/spy_component.dart
@@ -15,12 +15,12 @@ import 'spy_directive.dart';
       <button (click)="reset()">Reset Heroes</button>
 
       <p></p>
-      <div *ngFor="#hero of heroes" mySpy class="heroes">
+      <div *ngFor="let hero of heroes" mySpy class="heroes">
       {{hero}}
       </div>
 
       <h4>-- Spy Lifecycle Hook Log --</h4>
-      <div *ngFor="#msg of spyLog">{{msg}}</div>
+      <div *ngFor="let msg of spyLog">{{msg}}</div>
     </div>
     ''',
     styles: const [
diff --git a/public/docs/_examples/lifecycle-hooks/dart/pubspec.yaml b/public/docs/_examples/lifecycle-hooks/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/quickstart/dart/pubspec.yaml b/public/docs/_examples/quickstart/dart/pubspec.yaml
@@ -7,7 +7,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
 # #enddocregion no-rewriter
   dart_to_js_script_rewriter: ^1.0.1
diff --git a/public/docs/_examples/structural-directives/dart/pubspec.yaml b/public/docs/_examples/structural-directives/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/template-syntax/dart/lib/app_component.html b/public/docs/_examples/template-syntax/dart/lib/app_component.html
@@ -410,7 +410,7 @@ <h3>Result: {{currentHero.firstName}}</h3>
 <a class="to-toc" href="#toc">top</a>
 
 <!-- NgStyle binding -->
-<hr><h2>NgStyle Binding</h2>
+<hr><h2 id="ngStyle">NgStyle Binding</h2>
 
 <!-- #docregion NgStyle-1 -->
 <div [style.font-size]="isSpecial ? 'x-large' : 'smaller'" >
@@ -633,12 +633,11 @@ <h3>*ngFor expansion</h3>
 
 <p><i>expand to template = "..."</i></p>
 <div class="box">
-  <!-- *ngFor w/ hero-detail Component and a template "attribute" directive -->
+  <!-- ngFor w/ hero-detail Component and a template "attribute" directive -->
   <!-- #docregion Template-3 -->
   <hero-detail template="ngFor let hero of heroes; trackBy:trackByHeroes" [hero]="hero"></hero-detail>
   <!-- #enddocregion Template-3 -->
 </div>
-<br>
 
 <p><i>expand to &lt;template&gt;</i></p>
 <div class="box">
@@ -655,31 +654,31 @@ <h3>*ngFor expansion</h3>
 <!-- template local variable -->
 <hr><h2 id="local-vars">Template local variables</h2>
 
-<!-- #docregion var-phone -->
+<!-- #docregion ref-phone -->
 <!-- phone refers to the input element; pass its `value` to an event handler -->
 <input #phone placeholder="phone number">
 <button (click)="callPhone(phone.value)">Call</button>
 
 <!-- fax refers to the input element; pass its `value` to an event handler -->
-<input var-fax placeholder="phone number">
+<input ref-fax placeholder="fax number">
 <button (click)="callFax(fax.value)">Fax</button>
-<!-- #enddocregion var-phone -->
+<!-- #enddocregion ref-phone -->
 
 <h4>Example Form</h4>
-<!-- #docregion var-form -->
-<!-- #docregion var-form-a -->
+<!-- #docregion ref-form -->
+<!-- #docregion ref-form-a -->
 <form (ngSubmit)="onSubmit(theForm)" #theForm="ngForm">
-<!-- #enddocregion var-form-a -->
+<!-- #enddocregion ref-form-a -->
   <div class="form-group">
     <label for="name">Name</label>
-    <input id="name" class="form-control" required ngControl="firstName"
+    <input class="form-control" required ngControl="firstName"
         [(ngModel)]="currentHero.firstName">
   </div>
-  <!-- #docregion var-form-a -->
+<!-- #docregion ref-form-a -->
   <button type="submit" [disabled]="!theForm.form.valid">Submit</button>
 </form>
-<!-- #enddocregion var-form-a -->
-<!-- #enddocregion var-form -->
+<!-- #enddocregion ref-form-a -->
+<!-- #enddocregion ref-form -->
 <br><br>
 
 <!-- btn refers to the button element; show its disabled state -->
@@ -783,16 +782,18 @@ <h4>Example Form</h4>
 </div>
 
 
+<a class="to-toc" href="#toc">top</a>
+
 <!-- Todo: discuss this in the Style binding section -->
 <!-- enums in bindings -->
-<!--
+
 <hr><h2 id="enums">Enums in binding</h2>
 
+<!--<p>The name of the Color.red enum is {{color}}</p>-->
 <p>The current color number is {{color}}</p>
 <p><button [style.color]="color.toString()" (click)="colorToggle()">Enum Toggle</button>
 
 <a class="to-toc" href="#toc">top</a>
--->
 
 <!-- #docregion my-first-app -->
 <h3>My First Angular Application</h3>
diff --git a/public/docs/_examples/template-syntax/dart/pubspec.yaml b/public/docs/_examples/template-syntax/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/toh-1/dart/pubspec.yaml b/public/docs/_examples/toh-1/dart/pubspec.yaml
@@ -4,7 +4,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/toh-2/dart/lib/app_component.dart b/public/docs/_examples/toh-2/dart/lib/app_component.dart
@@ -14,7 +14,7 @@ class Hero {
       <h1>{{title}}</h1>
       <h2>My Heroes</h2>
       <ul class="heroes">
-        <li *ngFor="#hero of heroes"
+        <li *ngFor="let hero of heroes"
           [class.selected]="hero == selectedHero"
           (click)="onSelect(hero)">
           <span class="badge">{{hero.id}}</span> {{hero.name}}
diff --git a/public/docs/_examples/toh-2/dart/pubspec.yaml b/public/docs/_examples/toh-2/dart/pubspec.yaml
@@ -3,7 +3,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/toh-3/dart/lib/app_component.dart b/public/docs/_examples/toh-3/dart/lib/app_component.dart
@@ -15,7 +15,7 @@ import 'hero_detail_component.dart';
       <h1>{{title}}</h1>
       <h2>My Heroes</h2>
       <ul class="heroes">
-        <li *ngFor="#hero of heroes"
+        <li *ngFor="let hero of heroes"
           [class.selected]="hero == selectedHero"
           (click)="onSelect(hero)">
           <span class="badge">{{hero.id}}</span> {{hero.name}}
diff --git a/public/docs/_examples/toh-3/dart/pubspec.yaml b/public/docs/_examples/toh-3/dart/pubspec.yaml
@@ -3,7 +3,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/toh-4/dart/lib/app_component.dart b/public/docs/_examples/toh-4/dart/lib/app_component.dart
@@ -17,7 +17,7 @@ import 'hero_service.dart';
       <h1>{{title}}</h1>
       <h2>My Heroes</h2>
       <ul class="heroes">
-        <li *ngFor="#hero of heroes"
+        <li *ngFor="let hero of heroes"
           [class.selected]="hero == selectedHero"
           (click)="onSelect(hero)">
           <span class="badge">{{hero.id}}</span> {{hero.name}}
diff --git a/public/docs/_examples/toh-4/dart/lib/app_component_1.dart b/public/docs/_examples/toh-4/dart/lib/app_component_1.dart
@@ -13,7 +13,7 @@ import 'hero_service_1.dart';
 @Component(
     selector: 'my-app',
     template: '''
-    <div *ngFor="#hero of heroes" (click)="onSelect(hero)">
+    <div *ngFor="let hero of heroes" (click)="onSelect(hero)">
       {{hero.name}}
     </div>
     <my-hero-detail [hero]="selectedHero"></my-hero-detail>
diff --git a/public/docs/_examples/toh-4/dart/pubspec.yaml b/public/docs/_examples/toh-4/dart/pubspec.yaml
@@ -3,7 +3,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/toh-5/dart/pubspec.yaml b/public/docs/_examples/toh-5/dart/pubspec.yaml
@@ -5,7 +5,7 @@ version: 0.0.1
 environment:
   sdk: '>=1.13.0 <2.0.0'
 dependencies:
-  angular2: 2.0.0-beta.16
+  angular2: 2.0.0-beta.17
   browser: ^0.10.0
   dart_to_js_script_rewriter: ^1.0.1
 transformers:
diff --git a/public/docs/_examples/user-input/dart/lib/little_tour_component.dart b/public/docs/_examples/user-input/dart/lib/little_tour_component.dart
@@ -11,7 +11,7 @@ import 'package:angular2/core.dart';
 
       <button (click)=addHero(newHero.value)>Add</button>
 
-      <ul><li *ngFor="#hero of heroes">{{hero}}</li></ul>
+      <ul><li *ngFor="let hero of heroes">{{hero}}</li></ul>
     ''')
 class LittleTourComponent {
   List<String> heroes = ['Windstorm', 'Bombasto', 'Magneta', 'Tornado'];
diff --git a/public/docs/_examples/user-input/dart/pubspec.yaml b/public/docs/_examples/user-input/dart/pubspec.yaml
