-
Notifications
You must be signed in to change notification settings - Fork 3
Some Debian support for Apache #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* RedHat/Debian support added for a few more params. * Apache config file template gets RedHat/Debian support.
manifests/config.pp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am less keen on direct reference to $webalizer::params::apache_conffile in the manifest. Pass in apache_conffile like the other vars so that they it can be set optionally via hiera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough: I already changed it so the apache config file is a param for this class (with default from webalizer::params).
|
@jmnavarrol - I should have merged this before doing a new release. Please rebase and I'll look quickly this time. |
* Defaults to $webalizer::params::apache_conffile. * Suggested by traylenator.
Done. Please have a look at it. |
|
I set the default be redhat since it's easier to test and it's good style to specify a default Can you look at the tests failing. It's just looks to be some white space. THanks. |
These seem to be the errors (just a sample):
Yes, I indent using tabs instead of puppetlabs-suggested two spaces. It is an on purpose decision that I don't think I'm going to change in the near future, sorry. |
|
...in the meantime, I updated my master branch so the module can manage multiple webalizer conf files. You might want to have a look at it. |
A bit of Debian support added: