Skip to content

Conversation

@jmnavarrol
Copy link

A bit of Debian support added:

  • Supporting files get directly under /var/www/webalizer
  • The web basedir is /var/www/webalizer instead of /var/www/usage
  • Web alias becomes accordingly /webalizer instead of /usage
  • Apache config template gets modified along changes above.

* RedHat/Debian support added for a few more params.
* Apache config file template gets RedHat/Debian support.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am less keen on direct reference to $webalizer::params::apache_conffile in the manifest. Pass in apache_conffile like the other vars so that they it can be set optionally via hiera.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough: I already changed it so the apache config file is a param for this class (with default from webalizer::params).

@traylenator
Copy link
Contributor

@jmnavarrol - I should have merged this before doing a new release. Please rebase and I'll look quickly this time.

@jmnavarrol
Copy link
Author

@traylenator

Please rebase and I'll look quickly this time.

Done. Please have a look at it.

@traylenator
Copy link
Contributor

I set the default be redhat since it's easier to test and it's good style to specify a default
rather than just a compilation fail mid flight

Can you look at the tests failing. It's just looks to be some white space.

THanks.

@jmnavarrol
Copy link
Author

@traylenator:

Can you look at the tests failing. It's just looks to be some white space.

These seem to be the errors (just a sample):

manifests/config.pp - ERROR: tab character found on line 11
manifests/config.pp - ERROR: two-space soft tabs not used on line 11

Yes, I indent using tabs instead of puppetlabs-suggested two spaces. It is an on purpose decision that I don't think I'm going to change in the near future, sorry.

@jmnavarrol
Copy link
Author

...in the meantime, I updated my master branch so the module can manage multiple webalizer conf files.

You might want to have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants