diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 1cab913eff..15146edb3b 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -46,12 +46,12 @@ Delete this line and everything above, and then fill in the details below. - **What steps will reproduce the problem?** - - Please provide detailed information here, enough for someone else to reprodce your problem. + - Please provide detailed information here, enough for someone else to reproduce your problem. - Does the problem reproduce using the [MinimalExample](https://github.com/cefsharp/CefSharp.MinimalExample)? - If code is required to reproduce your problem then please provide one of the following - Fork the [MinimalExample](https://github.com/cefsharp/CefSharp.MinimalExample) and push your changes to `GitHub` (this is the preferred option). - Use a code sharing service list `Gist` or `Pastebin` - - Paste your **formatted code as part of this issue** (only do this for small amounts of code and make sure you **format the code so it's reabily**) + - Paste your **formatted code as part of this issue** (only do this for small amounts of code and make sure you **format the code so it's readable**) - Please no binary attachments (zip, 7z, etc), code needs to be easily reviewed in a web browser. - **What is the expected output? What do you see instead?** diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 2175c42139..275373f772 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -13,7 +13,7 @@ Please use one of the following to ask your questions: --- -`CefSharp` is a wrapper around the [Chromium Embedded Framework](https://bitbucket.org/chromiumembedded/cef/overview) in a lot of cases a feature must be added to `CEF` first before it can be used in `CefSharp`. `CEF` has it's own `Feature Request Forum` at https://magpcss.org/ceforum/viewforum.php?f=7 +`CefSharp` is a wrapper around the [Chromium Embedded Framework](https://bitbucket.org/chromiumembedded/cef/overview) in a lot of cases a feature must be added to `CEF` first before it can be used in `CefSharp`. `CEF` has its own `Feature Request Forum` at https://magpcss.org/ceforum/viewforum.php?f=7 --- diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e9193adbc8..c2d7925c5e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -5,7 +5,7 @@ - e.g. I have added a new feature to the Javascript Binding implementation **Changes:** [specify the structures changed] - - e.g. I have modified the Javascript Bindign Implementation + - e.g. I have modified the Javascript Binding Implementation - Added support for Async binding to return Task - Added new QUnit Test cases diff --git a/CefSharp.Core/Cef.h b/CefSharp.Core/Cef.h index 030a4a4eff..b2cf42d6d5 100644 --- a/CefSharp.Core/Cef.h +++ b/CefSharp.Core/Cef.h @@ -34,7 +34,7 @@ using namespace msclr::interop; namespace CefSharp { /// - /// Global CEF methods are exposed through this class. e.g. CefInitalize maps to Cef.Initialize + /// Global CEF methods are exposed through this class. e.g. CefInitialize maps to Cef.Initialize /// CEF API Doc https://magpcss.org/ceforum/apidocs3/projects/(default)/(_globals).html /// This class cannot be inherited. /// @@ -164,7 +164,7 @@ namespace CefSharp /// threads, your application will hang. See the documentation for Cef.Shutdown() for more details. /// /// CefSharp configuration settings. - /// Check that all relevant dependencies avaliable, throws exception if any are missing + /// Check that all relevant dependencies available, throws exception if any are missing /// true if successful; otherwise, false. static bool Initialize(CefSettingsBase^ cefSettings, bool performDependencyCheck) { @@ -176,11 +176,11 @@ namespace CefSharp /// /// Initializes CefSharp with user-provided settings. /// It's important to note that Initialize/Shutdown MUST be called on your main - /// applicaiton thread (Typically the UI thead). If you call them on different + /// application thread (typically the UI thread). If you call them on different /// threads, your application will hang. See the documentation for Cef.Shutdown() for more details. /// /// CefSharp configuration settings. - /// Check that all relevant dependencies avaliable, throws exception if any are missing + /// Check that all relevant dependencies available, throws exception if any are missing /// The handler for functionality specific to the browser process. Null if you don't wish to handle these events /// true if successful; otherwise, false. static bool Initialize(CefSettingsBase^ cefSettings, bool performDependencyCheck, IBrowserProcessHandler^ browserProcessHandler) @@ -197,14 +197,14 @@ namespace CefSharp /// threads, your application will hang. See the documentation for Cef.Shutdown() for more details. /// /// CefSharp configuration settings. - /// Check that all relevant dependencies avaliable, throws exception if any are missing + /// Check that all relevant dependencies available, throws exception if any are missing /// Implement this interface to provide handler implementations. Null if you don't wish to handle these events /// true if successful; otherwise, false. static bool Initialize(CefSettingsBase^ cefSettings, bool performDependencyCheck, IApp^ cefApp) { if (IsInitialized) { - // NOTE: Can only initialize Cef once, to make this explicitly clear throw exception on subsiquent attempts + // NOTE: Can only initialize Cef once, to make this explicitly clear throw exception on subsequent attempts throw gcnew Exception("CEF can only be initialized once per process. This is a limitation of the underlying " + "CEF/Chromium framework. You can change many (not all) settings at runtime through RequestContext.SetPreference. " + "See https://github.com/cefsharp/CefSharp/wiki/General-Usage#request-context-browser-isolation " + @@ -280,10 +280,10 @@ namespace CefSharp } /// - /// Perform a single iteration of CEF message loop processing.This function is + /// Perform a single iteration of CEF message loop processing. This function is /// provided for cases where the CEF message loop must be integrated into an /// existing application message loop. Use of this function is not recommended - /// for most users; use CefSettings.MultiThreadedMessageLoop if possible (the deault). + /// for most users; use CefSettings.MultiThreadedMessageLoop if possible (the default). /// When using this function care must be taken to balance performance /// against excessive CPU usage. It is recommended to enable the /// CefSettings.ExternalMessagePump option when using @@ -433,7 +433,7 @@ namespace CefSharp /// - Access the ICookieManager instance in IBrowserProcessHandler.OnContextInitialized. /// - Use the ChromiumWebBrowser BrowserInitialized (OffScreen) or IsBrowserInitializedChanged (WinForms/WPF) events. /// - /// If non-NULL it will be executed asnychronously on the CEF UI thread after the manager's storage has been initialized. + /// If non-NULL it will be executed asynchronously on the CEF UI thread after the manager's storage has been initialized. /// A the global cookie manager or null if the RequestContext has not yet been initialized. static ICookieManager^ GetGlobalCookieManager(ICompletionCallback^ callback) { @@ -449,7 +449,7 @@ namespace CefSharp } /// - /// Called prior to calling Cef.Shutdown, this diposes of any remaning + /// Called prior to calling Cef.Shutdown, this disposes of any remaining /// ChromiumWebBrowser instances. In WPF this is used from Dispatcher.ShutdownStarted /// to release the unmanaged resources held by the ChromiumWebBrowser instances. /// Generally speaking you don't need to call this yourself. @@ -870,9 +870,9 @@ namespace CefSharp /// /// Helper method to ensure all ChromiumWebBrowser instances have been /// closed/disposed, should be called before Cef.Shutdown. - /// Disposes all remaning ChromiumWebBrowser instances - /// then waits for CEF to release it's remaning CefBrowser instances. - /// Finally a small delay of 50ms to allow for CEF to finish it's cleanup. + /// Disposes all remaining ChromiumWebBrowser instances + /// then waits for CEF to release its remaining CefBrowser instances. + /// Finally a small delay of 50ms to allow for CEF to finish its cleanup. /// Should only be called when MultiThreadedMessageLoop = true; /// (Hasn't been tested when when CEF integrates into main message loop). ///