Ac 178 #6
Merged
Ac 178 #6
+547
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository Signed-off-by: Alex Nelson <[email protected]>
Member
Author
|
numpy requires Python >= 3.7. Need to think through how to resolve this. |
This does not address the CI-reported python3.6 error, but it is a necessary fix in the meanwhile. References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository Signed-off-by: Alex Nelson <[email protected]>
numpy, a pandas dependency, required Python > 3.7 as of version 1.20.0. Hence, case_sparql_select cannot import pandas in a Python 3.6 environment. This patch adds steps to disable dependency installation and tests for case_sparql_select if Python is detected to be < 3.7.x. As a reminder, Python 3.6 goes EOL on 2021-12-23. By or at that time, 3.6 will be removed from this project. References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository * [PEP-0494] https://www.python.org/dev/peps/pep-0494/#and-beyond-schedule * [numpy 1.20.0] https://pypi.org/project/numpy/1.20.0/ Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.