Skip to content

Conversation

@ajnelson-nist
Copy link
Member

This patch series adds two Make targets to the test environment so a manual format-review can be done:

  • Testing - cd tests ; make check-black
  • Formatting - cd tests ; make format

Further discussion needs to be had before these are added to CI steps.

References:

  • [AC-215] Evaluate pre-commit usage on casework repositories
  • [AC-216] Apply Black to all casework Python code bases

This patch adds two Make targets to the test environment so a manual
format-review can be done:

* Testing - `cd tests ; make check-black`
* Formatting - `cd tests ; make format`

Further discussion needs to be had before these are added to CI steps.

A follow-on patch will apply Black, so mechanical effects can be
separated from manual changes.

References:
* [AC-215] Evaluate pre-commit usage on casework repositories
* [AC-216] Apply Black to all casework Python code bases

Acked-by: kchason <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
References:
* [AC-216] Apply Black to all casework Python code bases

Acked-by: kchason <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
@kchason kchason merged commit f174764 into develop Mar 21, 2022
@ajnelson-nist ajnelson-nist deleted the AC-216 branch March 21, 2022 17:25
@ajnelson-nist ajnelson-nist mentioned this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants