Remove redundant computation

imaustink · imaustink · commit e9859938de28 · 2017-06-29T15:33:58.000-07:00
diff --git a/static/search.js b/static/search.js
@@ -523,7 +523,7 @@ var Search = Control.extend({
 					var $a = $(this);
 					var isLocal = this.hostname === location.hostname;
 					var isRelative = this.getAttribute('href').indexOf(location.hostname) === -1;
-					if(this.hostname !== location.hostname || this.protocol !== location.protocol){
+					if(!isLocal || this.protocol !== location.protocol){
 						$a.attr('target', '_blank');
 					}
 					if(isLocal && isRelative){

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ var Search = Control.extend({`
`523`	`523`	`var $a = $(this);`
`524`	`524`	`var isLocal = this.hostname === location.hostname;`
`525`	`525`	`var isRelative = this.getAttribute('href').indexOf(location.hostname) === -1;`
`526`		`- if(this.hostname !== location.hostname \|\| this.protocol !== location.protocol){`
	`526`	`+ if(!isLocal \|\| this.protocol !== location.protocol){`
`527`	`527`	`$a.attr('target', '_blank');`
`528`	`528`	`}`
`529`	`529`	`if(isLocal && isRelative){`