Skip to content

Commit b7f85a5

Browse files
authored
Fix in-page links (#509)
Also: - Remove old breadcrumb code - Remove the survey ad Fixes canjs/canjs#4826
1 parent d394d6f commit b7f85a5

File tree

15 files changed

+11
-531
lines changed

15 files changed

+11
-531
lines changed

sidebar/demo.stache

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
<div id="everything">
22
<div class="column" id="left">
3-
<div class="bottom">
4-
<canjs-sidebar
5-
class="nav-menu"
6-
searchMap:from="searchMap"
7-
selectedPageName:bind="selectedPageName"
8-
/>
9-
</div>
3+
<canjs-sidebar
4+
class="nav-menu"
5+
searchMap:from="searchMap"
6+
selectedPageName:bind="selectedPageName"
7+
/>
108
</div>
119
</div>
1210

sidebar/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = {
88
);
99
},
1010
safeInset: {
11-
bottom: 49,
12-
top: 101
11+
bottom: 0,
12+
top: 53 // @brand-height
1313
}
1414
};

sidebar/view-callbacks.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ var canViewCallbacks = require('can-view-callbacks');
22
var utils = require('./utils');
33

44
canViewCallbacks.attr('selected-in-sidebar', function(element) {
5-
var containerElement = document.querySelector('#left .bottom');
5+
var containerElement = document.querySelector('#left');
66
if (!containerElement) {
77
return;
88
}

static/breadcrumb.less

Lines changed: 0 additions & 150 deletions
This file was deleted.

0 commit comments

Comments
 (0)