Merge pull request #355 from canjs/352-fix-links-in-search-results

Fixed #352 Clicking links inside search results doesn't work

Author: imaustink

static/canjs.js

@@ -36,13 +36,12 @@ var $articleContainer,
 	// Override link behavior
 	$(document.body).on("click", "a", function(ev) {
 		var noModifierKeys = !ev.altKey && !ev.ctrlKey && !ev.metaKey && !ev.shiftKey,
-				sameHostname = this.hostname === window.location.hostname,
-				sameProtocol = this.protocol === window.location.protocol;
+			sameHostname = (ev.target.hostname || this.hostname) === window.location.hostname,
+			sameProtocol = (ev.target.protocol || this.protocol) === window.location.protocol;
 
 		if (noModifierKeys && sameHostname && sameProtocol) {
 			ev.preventDefault();
-			var href = this.href;
-			navigate(href);
+			navigate(ev.target.href || this.href);
 		}
 	}).on('keyup', 'input[type="checkbox"]', function(e){
 		var $target = $(e.target);

static/search.js

@@ -516,6 +516,17 @@ var Search = Control.extend({
 				}
 
 				return "/" + this.url;
+			},
+			addTargetToExternalURLs: function(html){
+				var $html = $('<div>').html(html);
+				$html.find('a').each(function(){
+					var $a = $(this);
+					var a = $a[0];
+					if(a.hostname !== location.hostname || a.protocol !== location.protocol){
+						$a.attr('target', '_blank');
+					}
+				});
+				return $html.contents();
 			}
 		});
 

templates/search-results.stache

@@ -30,7 +30,7 @@
 
             {{#if result.description}}
               <div class="result-description" title="{{result.description}}">
-                {{{result.description}}}
+                {{{addTargetToExternalURLs(result.description)}}}
               </div>
             {{/if}}
           </a>