From caef01c862307be5673b5e3185da720f79610b3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Mon, 1 Sep 2025 15:50:26 +0200 Subject: [PATCH 1/2] Use "node --run" over "npm run" in scripts --- apps/test-app/package.json | 16 ++++++++-------- package.json | 6 +++--- packages/ferric-example/package.json | 2 +- packages/host/package.json | 4 ++-- packages/node-addon-examples/package.json | 6 +++--- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/apps/test-app/package.json b/apps/test-app/package.json index 3113fa4f..4f52b082 100644 --- a/apps/test-app/package.json +++ b/apps/test-app/package.json @@ -8,15 +8,15 @@ "ios": "react-native run-ios --no-packager", "pod-install": "cd ios && pod install", "test:android": "mocha-remote --exit-on-error -- concurrently --kill-others-on-fail --passthrough-arguments npm:metro 'npm:android -- {@}' --", - "test:android:allTests": "MOCHA_REMOTE_CONTEXT=allTests npm run test:android -- ", - "test:android:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples npm run test:android -- ", - "test:android:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests npm run test:android -- ", - "test:android:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample npm run test:android -- ", + "test:android:allTests": "MOCHA_REMOTE_CONTEXT=allTests node --run test:android -- ", + "test:android:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples node --run test:android -- ", + "test:android:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests node --run test:android -- ", + "test:android:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample node --run test:android -- ", "test:ios": "mocha-remote --exit-on-error -- concurrently --passthrough-arguments --kill-others-on-fail npm:metro 'npm:ios -- {@}' --", - "test:ios:allTests": "MOCHA_REMOTE_CONTEXT=allTests npm run test:ios -- ", - "test:ios:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples npm run test:ios -- ", - "test:ios:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests npm run test:ios -- ", - "test:ios:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample npm run test:ios -- " + "test:ios:allTests": "MOCHA_REMOTE_CONTEXT=allTests node --run test:ios -- ", + "test:ios:nodeAddonExamples": "MOCHA_REMOTE_CONTEXT=nodeAddonExamples node --run test:ios -- ", + "test:ios:nodeTests": "MOCHA_REMOTE_CONTEXT=nodeTests node --run test:ios -- ", + "test:ios:ferricExample": "MOCHA_REMOTE_CONTEXT=ferricExample node --run test:ios -- " }, "dependencies": { "@babel/core": "^7.26.10", diff --git a/package.json b/package.json index 32b65bd3..f0cd5182 100644 --- a/package.json +++ b/package.json @@ -21,9 +21,9 @@ "lint": "eslint .", "prettier:check": "prettier --experimental-cli --check .", "prettier:write": "prettier --experimental-cli --write .", - "test": "npm run test --workspace react-native-node-api --workspace cmake-rn --workspace gyp-to-cmake --workspace node-addon-examples", - "bootstrap": "npm run build && npm run bootstrap --workspaces --if-present", - "prerelease": "npm run build && npm run prerelease --workspaces --if-present", + "test": "npm test --workspace react-native-node-api --workspace cmake-rn --workspace gyp-to-cmake --workspace node-addon-examples", + "bootstrap": "node --run build && npm run bootstrap --workspaces --if-present", + "prerelease": "node --run build && npm run prerelease --workspaces --if-present", "release": "changeset publish" }, "author": { diff --git a/packages/ferric-example/package.json b/packages/ferric-example/package.json index 02219ebc..73678bb3 100644 --- a/packages/ferric-example/package.json +++ b/packages/ferric-example/package.json @@ -13,7 +13,7 @@ "types": "ferric_example.d.ts", "scripts": { "build": "ferric build", - "bootstrap": "npm run build" + "bootstrap": "node --run build" }, "devDependencies": { "ferric-cli": "*" diff --git a/packages/host/package.json b/packages/host/package.json index 714dfad7..95a34a16 100644 --- a/packages/host/package.json +++ b/packages/host/package.json @@ -47,8 +47,8 @@ "build-weak-node-api": "cmake-rn --no-auto-link --no-weak-node-api-linkage --xcframework-extension --source ./weak-node-api --out ./weak-node-api", "build-weak-node-api:all-triplets": "cmake-rn --android --apple --no-auto-link --no-weak-node-api-linkage --xcframework-extension --source ./weak-node-api --out ./weak-node-api", "test": "tsx --test --test-reporter=@reporters/github --test-reporter-destination=stdout --test-reporter=spec --test-reporter-destination=stdout src/node/**/*.test.ts src/node/*.test.ts", - "bootstrap": "npm run copy-node-api-headers && npm run generate-weak-node-api-injector && npm run generate-weak-node-api && npm run build-weak-node-api", - "prerelease": "npm run copy-node-api-headers && npm run generate-weak-node-api-injector && npm run generate-weak-node-api && npm run build-weak-node-api:all-triplets" + "bootstrap": "node --run copy-node-api-headers && node --run generate-weak-node-api-injector && node --run generate-weak-node-api && node --run build-weak-node-api", + "prerelease": "node --run copy-node-api-headers && node --run generate-weak-node-api-injector && node --run generate-weak-node-api && node --run build-weak-node-api:all-triplets" }, "keywords": [ "react-native", diff --git a/packages/node-addon-examples/package.json b/packages/node-addon-examples/package.json index 1ca8e725..adae7591 100644 --- a/packages/node-addon-examples/package.json +++ b/packages/node-addon-examples/package.json @@ -13,10 +13,10 @@ "copy-examples": "tsx scripts/copy-examples.mts", "gyp-to-cmake": "gyp-to-cmake .", "build": "tsx scripts/build-examples.mts", - "copy-and-build": "npm run copy-examples && npm run gyp-to-cmake && npm run build", + "copy-and-build": "node --run copy-examples && node --run gyp-to-cmake && node --run build", "verify": "tsx scripts/verify-prebuilds.mts", - "test": "npm run copy-and-build && npm run verify", - "bootstrap": "npm run copy-and-build" + "test": "node --run copy-and-build && node --run verify", + "bootstrap": "node --run copy-and-build" }, "devDependencies": { "cmake-rn": "*", From 3a44ce1e3700c6a11f14969f026a0efaf5b6a3ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Thu, 4 Sep 2025 23:00:29 +0200 Subject: [PATCH 2/2] Triggering a new run