Skip to content

Commit d9f5485

Browse files
committed
Fix missing set_target_properties of .node suffix
1 parent 9688e2f commit d9f5485

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/gyp-to-cmake/src/transformer.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ export function bindingGypToCmakeLists({
113113
escapedIncludes.push("${CMAKE_JS_INC}");
114114
}
115115

116-
lines.push(`add_library(${targetName} SHARED ${escapedSources.join(" ")})`);
116+
lines.push(
117+
`add_library(${targetName} SHARED ${escapedSources.join(" ")})`,
118+
`set_target_properties(${targetName} PROPERTIES PREFIX "" SUFFIX ".node")`,
119+
);
117120

118121
if (libraries.length > 0) {
119122
lines.push(

0 commit comments

Comments
 (0)