Skip to content

Commit 6c4dee4

Browse files
committed
Remove unused code
1 parent 163a0f5 commit 6c4dee4

File tree

1 file changed

+0
-16
lines changed
  • packages/react-native-node-api-cmake/src

1 file changed

+0
-16
lines changed

packages/react-native-node-api-cmake/src/android.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ export function getAndroidConfigureCmakeArgs({
4848
);
4949
const architecture = ANDROID_ARCHITECTURES[triplet];
5050

51-
const linkerFlags: string[] = [
52-
// `--no-version-undefined`,
53-
// `--whole-archive`,
54-
// `--no-whole-archive`,
55-
];
56-
5751
return [
5852
// Use the XCode as generator for Apple platforms
5953
"-G",
@@ -68,8 +62,6 @@ export function getAndroidConfigureCmakeArgs({
6862
// `CMAKE_INSTALL_PREFIX=${installPath}`,
6963
// "-D",
7064
// `CMAKE_BUILD_TYPE=${configuration}`,
71-
"-D",
72-
"CMAKE_MAKE_PROGRAM=ninja",
7365
// "-D",
7466
// "CMAKE_C_COMPILER_LAUNCHER=ccache",
7567
// "-D",
@@ -84,13 +76,5 @@ export function getAndroidConfigureCmakeArgs({
8476
// `ANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL}`,
8577
"-D",
8678
"ANDROID_STL=c++_shared",
87-
// Pass linker flags to avoid errors from undefined symbols
88-
// TODO: Link against a weak-node-api to avoid this (or whatever other lib which will be providing the symbols)
89-
// "-D",
90-
// `CMAKE_SHARED_LINKER_FLAGS="-Wl,--allow-shlib-undefined"`,
91-
"-D",
92-
`CMAKE_SHARED_LINKER_FLAGS=${linkerFlags
93-
.map((flag) => `-Wl,${flag}`)
94-
.join(" ")}`,
9579
];
9680
}

0 commit comments

Comments
 (0)