@@ -48,12 +48,6 @@ export function getAndroidConfigureCmakeArgs({
48
48
) ;
49
49
const architecture = ANDROID_ARCHITECTURES [ triplet ] ;
50
50
51
- const linkerFlags : string [ ] = [
52
- // `--no-version-undefined`,
53
- // `--whole-archive`,
54
- // `--no-whole-archive`,
55
- ] ;
56
-
57
51
return [
58
52
// Use the XCode as generator for Apple platforms
59
53
"-G" ,
@@ -68,8 +62,6 @@ export function getAndroidConfigureCmakeArgs({
68
62
// `CMAKE_INSTALL_PREFIX=${installPath}`,
69
63
// "-D",
70
64
// `CMAKE_BUILD_TYPE=${configuration}`,
71
- "-D" ,
72
- "CMAKE_MAKE_PROGRAM=ninja" ,
73
65
// "-D",
74
66
// "CMAKE_C_COMPILER_LAUNCHER=ccache",
75
67
// "-D",
@@ -84,13 +76,5 @@ export function getAndroidConfigureCmakeArgs({
84
76
// `ANDROID_NATIVE_API_LEVEL=${ANDROID_API_LEVEL}`,
85
77
"-D" ,
86
78
"ANDROID_STL=c++_shared" ,
87
- // Pass linker flags to avoid errors from undefined symbols
88
- // TODO: Link against a weak-node-api to avoid this (or whatever other lib which will be providing the symbols)
89
- // "-D",
90
- // `CMAKE_SHARED_LINKER_FLAGS="-Wl,--allow-shlib-undefined"`,
91
- "-D" ,
92
- `CMAKE_SHARED_LINKER_FLAGS=${ linkerFlags
93
- . map ( ( flag ) => `-Wl,${ flag } ` )
94
- . join ( " " ) } `,
95
79
] ;
96
80
}
0 commit comments