Skip to content

Commit 2ca36b5

Browse files
committed
Incorporated feedback from CoPilot
1 parent 8a00dcd commit 2ca36b5

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

packages/cmake-rn/src/cli.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,7 @@ program = program.action(
143143
platform,
144144
buildPath: targetBuildPath,
145145
outputPath: path.join(targetBuildPath, "out"),
146-
options: baseOptions as BaseOpts &
147-
ReturnType<typeof platform.buildArgs>,
146+
options: baseOptions,
148147
};
149148
});
150149

packages/cmake-rn/src/platforms/android.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ export const platform: Platform<Target[], AndroidOpts> = {
8585
const architecture = ANDROID_ARCHITECTURES[target];
8686

8787
return [
88-
// Use the XCode as generator for Apple platforms
8988
"-G",
9089
"Ninja",
9190
"--toolchain",

packages/cmake-rn/src/platforms/apple.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,12 @@ export const platform: Platform<Target[], AppleOpts> = {
116116
},
117117
configureArgs({ target }) {
118118
return [
119-
// Use the XCode as generator for Apple platforms
120119
"-G",
121120
"Xcode",
122121
"-D",
123122
`CMAKE_SYSTEM_NAME=${CMAKE_SYSTEM_NAMES[target]}`,
124-
// Set the SDK path for the target platform
125123
"-D",
126124
`CMAKE_OSX_SYSROOT=${XCODE_SDK_NAMES[target]}`,
127-
// Set the target architecture
128125
"-D",
129126
`CMAKE_OSX_ARCHITECTURES=${APPLE_ARCHITECTURES[target]}`,
130127
];

0 commit comments

Comments
 (0)