refactor: improvements

Author: satya164

.circleci/config.yml

@@ -8,65 +8,79 @@ executors:
     environment:
       YARN_CACHE_FOLDER: "~/.cache/yarn"
 
+commands:
+  attach_project:
+    steps:
+      - attach_workspace:
+          at: ~/project
+
 jobs:
   install-dependencies:
     executor: default
     steps:
       - checkout
-      - attach_workspace:
-          at: ~/project
+      - attach_project
       - restore_cache:
           keys:
-            - yarn-{{ checksum "package.json" }}
-            - yarn-
+            - yarn-packages-v1-{{ .Branch }}-{{ checksum "yarn.lock" }}
+            - yarn-packages-v1-{{ .Branch }}-
+            - yarn-packages-v1-
       - run:
-          name: Install dependencies
-          command: |
-            yarn install --frozen-lockfile
+          name: Install project dependencies
+          command: yarn install --frozen-lockfile
       - save_cache:
-          key: yarn-{{ checksum "package.json" }}
+          key: yarn-packages-v1-{{ .Branch }}-{{ checksum "yarn.lock" }}
           paths: ~/.cache/yarn
       - persist_to_workspace:
           root: .
           paths: .
-  lint:
-      executor: default
-      steps:
-        - attach_workspace:
-            at: ~/project
-        - run:
-            name: Lint
-            command: |
-              yarn lint
-  typescript:
-      executor: default
-      steps:
-        - attach_workspace:
-            at: ~/project
-        - run:
-            name: Typecheck
-            command: |
-              yarn typescript
-  build-package:
-      executor: default
-      steps:
-        - attach_workspace:
-            at: ~/project
-        - run:
-            name: Compile
-            command: |
-              yarn prepare
+
+  lint-and-typecheck:
+    executor: default
+    steps:
+      - attach_project
+      - run:
+          name: Lint files
+          command: yarn lint
+      - run:
+          name: Typecheck files
+          command: yarn typescript
+
+  unit-tests:
+    executor: default
+    steps:
+      - attach_project
+      - run:
+          name: Run unit tests
+          command: yarn test --maxWorkers=2 --coverage
+      - run:
+          name: Upload test coverage
+          command: yarn codecov
+      - store_artifacts:
+          path: coverage
+          destination: coverage
+
+  build-packages:
+    executor: default
+    steps:
+      - attach_project
+      - run:
+          name: Build packages in the monorepo
+          command: yarn lerna run prepare
+      - run:
+          name: Verify built type definitions are correct
+          command: yarn typescript
 
 workflows:
   build-and-test:
     jobs:
       - install-dependencies
-      - lint:
+      - lint-and-typecheck:
           requires:
             - install-dependencies
-      - typescript:
+      - unit-tests:
           requires:
             - install-dependencies
-      - build-package:
+      - build-packages:
           requires:
             - install-dependencies

.eslintignore

@@ -0,0 +1,3 @@
+node_modules/
+lib/
+templates/

.gitignore

@@ -75,3 +75,4 @@ typings/
 
 # generated files
 lib/
+typescript/

package.json

@@ -12,9 +12,9 @@
     "node": ">= 10.0.0"
   },
   "scripts": {
-    "lint": "eslint \"packages/**/*.{js,ts,tsx}\"",
-    "typescript": "lerna run typescript",
-    "build": "lerna run build"
+    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "typescript": "tsc --noEmit",
+    "watch": "concurrently 'yarn typescript --watch' 'lerna run --parallel prepare -- --watch'"
   },
   "dependencies": {
     "@babel/core": "^7.12.10",
@@ -32,6 +32,7 @@
     "@commitlint/config-conventional": "^11.0.0",
     "@release-it/conventional-changelog": "^2.0.0",
     "commitlint": "^11.0.0",
+    "concurrently": "^5.3.0",
     "eslint": "^7.15.0",
     "eslint-config-satya164": "^3.1.8",
     "husky": "^4.3.6",
@@ -61,9 +62,8 @@
   "eslintIgnore": [
     "node_modules/",
     "coverage/",
-    "packages/cli/lib/",
-    "packages/builder/lib/",
-    "packages/builder/templates/"
+    "packages/*/lib/",
+    "packages/create-react-native-library/templates/"
   ],
   "prettier": {
     "singleQuote": true,

packages/builder/tsconfig.json

@@ -0,0 +1,3 @@
+@echo off
+
+node "%~dp0\create-react-native-library" %*

packages/cli/tsconfig.json

@@ -1,12 +1,15 @@
 {
-  "name": "react-native-builder-bob",
+  "name": "create-react-native-library",
   "version": "0.17.1",
   "description": "CLI to build JavaScript files for React Native libraries",
   "repository": "[email protected]:callstack/react-native-builder-bob.git",
   "homepage": "https://github.com/callstack/react-native-builder-bob/blob/main/README.md",
   "author": "Satyajit Sahoo <[email protected]>",
   "license": "MIT",
   "main": "lib/index.js",
+  "bin": {
+    "create-react-native-library": "bin/create-react-native-library"
+  },
   "files": [
     "lib",
     "templates"
@@ -19,12 +22,7 @@
     "registry": "https://registry.npmjs.org/"
   },
   "scripts": {
-    "lint": "eslint \"**/*.{js,ts,tsx}\"",
-    "typescript": "tsc --noEmit",
-    "build": "babel --root-mode upward --extensions .ts,.tsx src --out-dir lib --ignore '**/__tests__/**' --source-maps --delete-dir-on-start",
-    "watch": "concurrently 'yarn typescript --watch' 'yarn build --watch'",
-    "prepare": "yarn build",
-    "release": "release-it"
+    "prepare": "babel --extensions .ts,.tsx src --out-dir lib --ignore '**/__tests__/**' --source-maps --delete-dir-on-start"
   },
   "dependencies": {
     "chalk": "^4.1.0",
@@ -43,33 +41,13 @@
   "devDependencies": {
     "@babel/cli": "^7.12.10",
     "@commitlint/config-conventional": "^11.0.0",
-    "@release-it/conventional-changelog": "^2.0.0",
     "@types/chalk": "^2.2.0",
     "@types/cross-spawn": "^6.0.2",
     "@types/dedent": "^0.7.0",
     "@types/ejs": "^3.0.5",
     "@types/fs-extra": "^9.0.5",
     "@types/prompts": "^2.0.9",
     "@types/validate-npm-package-name": "^3.0.2",
-    "@types/yargs": "^15.0.12",
-    "concurrently": "^5.3.0",
-    "release-it": "^14.2.2"
-  },
-  "release-it": {
-    "git": {
-      "commitMessage": "chore: release ${version}",
-      "tagName": "v${version}"
-    },
-    "npm": {
-      "publish": true
-    },
-    "github": {
-      "release": true
-    },
-    "plugins": {
-      "@release-it/conventional-changelog": {
-        "preset": "angular"
-      }
-    }
+    "@types/yargs": "^15.0.12"
   }
 }