Skip to content

Conversation

@Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Apr 20, 2021

why?

We allow user to remove getversion call in their workflows. Current implementation throws a non-deterministic error if the getversion call before upsertsearchattributes is removed

test?
new unit test

@Shaddoll Shaddoll requested review from a team, meiliang86, mkolodezny and yux0 April 20, 2021 02:53
@meiliang86
Copy link
Contributor

Add a unit test (maybe a replay test)?

@meiliang86
Copy link
Contributor

Check WorkflowTests.java. You should find existing tests that you can borrow.

@coveralls
Copy link

coveralls commented Apr 20, 2021

Pull Request Test Coverage Report for Build 641

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 71.823%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java 1 82.46%
Totals Coverage Status
Change from base Build 632: 0.009%
Covered Lines: 10665
Relevant Lines: 14849

💛 - Coveralls

@Shaddoll Shaddoll merged commit 95d4ab4 into cadence-workflow:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants