Use ERROR_STOPPED_ON_SYMLINK on Windows for symlink errors.

sunfishcode · sunfishcode · commit f5bdc815213d · 2021-01-25T19:26:35.000-08:00
When `FollowSymlinks::No` and a symlink is encountered, on Windows, use
`ERROR_STOPPED_ON_SYMLINK` as the error code.
diff --git a/cap-primitives/src/windows/fs/open_unchecked.rs b/cap-primitives/src/windows/fs/open_unchecked.rs
@@ -48,7 +48,7 @@ pub(crate) fn open_unchecked(
                     // them as a distinct error.
                     if metadata.file_type().is_symlink() {
                         return Err(OpenUncheckedError::Symlink(
-                            io::Error::new(io::ErrorKind::Other, "symlink encountered"),
+                            io::Error::from_raw_os_error(winerror::ERROR_STOPPED_ON_SYMLINK as i32),
                             if metadata.file_attributes() & FILE_ATTRIBUTE_DIRECTORY
                                 == FILE_ATTRIBUTE_DIRECTORY
                             {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ pub(crate) fn open_unchecked(`
`48`	`48`	`// them as a distinct error.`
`49`	`49`	`if metadata.file_type().is_symlink() {`
`50`	`50`	`return Err(OpenUncheckedError::Symlink(`
`51`		`- io::Error::new(io::ErrorKind::Other, "symlink encountered"),`
	`51`	`+ io::Error::from_raw_os_error(winerror::ERROR_STOPPED_ON_SYMLINK as i32),`
`52`	`52`	`if metadata.file_attributes() & FILE_ATTRIBUTE_DIRECTORY`
`53`	`53`	`== FILE_ATTRIBUTE_DIRECTORY`
`54`	`54`	`{`