Skip to content

Conversation

@brianc
Copy link
Owner

@brianc brianc commented Apr 23, 2025

This replaces this old PR here. Added some more tests to the exports from pg, too.

@brianc brianc merged commit ad3e603 into master Apr 23, 2025
13 checks passed
@B4nan
Copy link

B4nan commented Apr 27, 2025

Thanks for this, but please note that the types package is still outdated.

@brianc
Copy link
Owner Author

brianc commented Apr 27, 2025 via email

@B4nan
Copy link

B4nan commented Apr 28, 2025

just to be clear, i am talking about the @types/pg package. would be great to move the type definitions here, its a shame such a popular and maintained package is not maintaining the types together with the code.

@brianc
Copy link
Owner Author

brianc commented Apr 28, 2025

just to be clear, i am talking about the @types/pg package. would be great to move the type definitions here, its a shame such a popular and maintained package is not maintaining the types together with the code.

ohhhhhhhh i see. Yeah I would like to move the type definitions to this library. I also want to convert the rest of this library to typescript. I was gonna do typedefs first, so then its easier to align the typescript to them. 😄 definitely on my todo list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants