fix(int-aws-support): SqsOutboundChannelAdapterParser sync attribute

Author: boolivar

int-aws-support/src/main/java/org/springframework/integration/aws/support/config/xml/parsers/SqsOutboundChannelAdapterParser.java

@@ -1,18 +1,19 @@
 package org.springframework.integration.aws.support.config.xml.parsers;
 
-import org.springframework.beans.factory.config.TypedStringValue;
 import org.springframework.beans.factory.support.AbstractBeanDefinition;
 import org.springframework.beans.factory.xml.ParserContext;
+import org.springframework.integration.aws.config.xml.ValueFactory;
 import org.springframework.integration.aws.config.xml.XmlBeanDefinitionBuilder;
 import org.springframework.integration.aws.outbound.SqsMessageHandler;
+import org.springframework.integration.aws.support.config.xml.InvertedBooleanFactoryBean;
 import org.springframework.integration.config.xml.AbstractOutboundChannelAdapterParser;
 import org.w3c.dom.Element;
 
 public class SqsOutboundChannelAdapterParser extends AbstractOutboundChannelAdapterParser {
 
     @Override
     protected AbstractBeanDefinition parseConsumer(Element element, ParserContext parserContext) {
-        var builder = XmlBeanDefinitionBuilder.newInstance(element, parserContext, SqsMessageHandler.class)
+        return XmlBeanDefinitionBuilder.newInstance(element, parserContext, SqsMessageHandler.class)
             .unsupportedAttributeWarning("failure-channel", "resource-id-resolver", "error-message-strategy", "async-handler")
             .addConstructorArgReference("sqs")
             .setPropertyOrExpressionStringIfAttributeDefined("queue")
@@ -22,19 +23,7 @@ protected AbstractBeanDefinition parseConsumer(Element element, ParserContext pa
             .setPropertyOrExpressionStringIfAttributeDefined("send-timeout")
             .setPropertyReferenceIfAttributeDefined("message-converter")
             .setPropertyIfAttributeDefined("success-channel", "outputChannelName")
-            ;
-
-        if (element.hasAttribute("sync")) {
-            var sync = element.getAttribute("sync");
-            if ("true".equalsIgnoreCase(sync)) {
-                builder.getBeanDefinitionBuilder().addPropertyValue("async", new TypedStringValue("false"));
-            } else if ("false".equalsIgnoreCase(sync)) {
-                builder.getBeanDefinitionBuilder().addPropertyValue("async", new TypedStringValue("true"));
-            } else {
-                builder.error("expected boolean for 'sync' attribute");
-            }
-        }
-
-        return builder.build();
+            .setPropertyIfAttributeDefined("sync", "async", ValueFactory.bean(InvertedBooleanFactoryBean.class))
+            .build();
     }
 }

int-aws-support/src/test/java/org/springframework/integration/aws/support/config/xml/parsers/SqsOutboundChannelAdapterParserTest.java

@@ -31,7 +31,7 @@ void testMessageHandler() {
                     id="soca"
                     channel="c"
                     sqs="sqs"
-                    sync="false"
+                    sync="#{false}"
                     message-converter="mc"
                     error-message-strategy="ems"
                     success-channel="sc"