Pyarn add - take 2 - initial refactoring #27
Conversation
| @@ -0,0 +1,77 @@ | |||
| // @flow | |||
|
|
|||
| import { getFixturePath } from 'jest-fixtures'; | |||
There was a problem hiding this comment.
This util is not finished yet. I realised I needed to have all of symlinking working first.
| @@ -0,0 +1,31 @@ | |||
| // @flow | |||
|
|
|||
There was a problem hiding this comment.
Unfinished, as it was waiting on symlinking
| dependencies: '', | ||
| devDependencies: '--dev', | ||
| peerDependencies: '--peer', | ||
| optionalDependencies: '--optional' |
There was a problem hiding this comment.
I think it'd be better to have this conversion up in the commands rather than in the utilities
There was a problem hiding this comment.
I thought we said in the last PR that the utility should convert js options to cli options and commands should be converting from flags to js options?
https://github.com/pyarn/pyarn/pull/17/files#r138537987
There was a problem hiding this comment.
Ohhh, I read this code backwards, I thought you were converting flags to types not types to flags
There was a problem hiding this comment.
Yea, I might refactor using Keys later https://flow.org/en/docs/types/utilities/#toc-keys
| dependencies: Array<Dependency>, | ||
| type?: configDependencyType | ||
| ) { | ||
| const isProjectPackage = project.pkg.dir === pkg.dir; |
There was a problem hiding this comment.
pkg.isSamePackage(project.pkg)There was a problem hiding this comment.
Ah yea, I was waiting for the remove PR.
|
|
||
| test('removing a dependency that is used by a workspace', async () => { | ||
| let { tempDir } = await copyFixtureIntoTempDir( | ||
| test.only('removing a dependency that is used by a workspace', async () => { |
This is the initial refactoring for pyarn add.
It add yarn.add and symlinkPackageDependencies.
TODO: