comment

Alex Peck · Alex Peck · commit 298fb20f2a22 · 2023-09-11T15:21:22.000-07:00
diff --git a/BitFaster.Caching/Lfu/ConcurrentLfu.cs b/BitFaster.Caching/Lfu/ConcurrentLfu.cs
@@ -334,6 +334,7 @@ public bool TryRemove(KeyValuePair<K, V> item)
 #if NET6_0_OR_GREATER
                     if (this.dictionary.TryRemove(kvp))
 #else
+                    // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/
                     if (((ICollection<KeyValuePair<K, LfuNode<K, V>>>)this.dictionary).Remove(kvp))
 #endif
                     {
diff --git a/BitFaster.Caching/Lru/ClassicLru.cs b/BitFaster.Caching/Lru/ClassicLru.cs
@@ -253,6 +253,7 @@ public bool TryRemove(KeyValuePair<K, V> item)
 #if NET6_0_OR_GREATER
                     if (this.dictionary.TryRemove(kvp))
 #else
+                    // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/
                     if (((ICollection<KeyValuePair<K, LinkedListNode<LruItem>>>)this.dictionary).Remove(kvp))
 #endif
                     {
diff --git a/BitFaster.Caching/Lru/ConcurrentLruCore.cs b/BitFaster.Caching/Lru/ConcurrentLruCore.cs
@@ -308,6 +308,7 @@ public bool TryRemove(KeyValuePair<K, V> item)
 #if NET6_0_OR_GREATER
                     if (this.dictionary.TryRemove(kvp))
 #else
+                    // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/
                     if (((ICollection<KeyValuePair<K, I>>)this.dictionary).Remove(kvp))
 #endif
                     {

Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,7 @@ public bool TryRemove(KeyValuePair<K, V> item)`
`334`	`334`	`#if NET6_0_OR_GREATER`
`335`	`335`	`if (this.dictionary.TryRemove(kvp))`
`336`	`336`	`#else`
	`337`	`+ // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/`
`337`	`338`	`if (((ICollection<KeyValuePair<K, LfuNode<K, V>>>)this.dictionary).Remove(kvp))`
`338`	`339`	`#endif`
`339`	`340`	`{`
Original file line number	Diff line number	Diff line change
`@@ -253,6 +253,7 @@ public bool TryRemove(KeyValuePair<K, V> item)`
`253`	`253`	`#if NET6_0_OR_GREATER`
`254`	`254`	`if (this.dictionary.TryRemove(kvp))`
`255`	`255`	`#else`
	`256`	`+ // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/`
`256`	`257`	`if (((ICollection<KeyValuePair<K, LinkedListNode<LruItem>>>)this.dictionary).Remove(kvp))`
`257`	`258`	`#endif`
`258`	`259`	`{`
Original file line number	Diff line number	Diff line change
`@@ -308,6 +308,7 @@ public bool TryRemove(KeyValuePair<K, V> item)`
`308`	`308`	`#if NET6_0_OR_GREATER`
`309`	`309`	`if (this.dictionary.TryRemove(kvp))`
`310`	`310`	`#else`
	`311`	`+ // https://devblogs.microsoft.com/pfxteam/little-known-gems-atomic-conditional-removals-from-concurrentdictionary/`
`311`	`312`	`if (((ICollection<KeyValuePair<K, I>>)this.dictionary).Remove(kvp))`
`312`	`313`	`#endif`
`313`	`314`	`{`