feat(grit): match JS object members using spread metavariable $... (#7447)

Author: rriski

.changeset/fast-parts-argue.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixes [#7446](https://github.com/biomejs/biome/issues/7446). The GritQL `$...` spread metavariable now correctly matches members in object literals, aligning its behavior with arrays and function calls.

crates/biome_grit_patterns/src/pattern_compiler/snippet_compiler.rs

@@ -0,0 +1,5 @@
+or {
+  `[$..., 1, $...]`,
+  `{ key: 1, $... }`,
+  `fn($...)`
+}

crates/biome_grit_patterns/tests/specs/ts/spreadMetavariable.grit

@@ -0,0 +1,20 @@
+---
+source: crates/biome_grit_patterns/tests/spec_tests.rs
+expression: spreadMetavariable
+---
+SnapshotResult {
+    messages: [],
+    matched_ranges: [
+        "1:14-1:23",
+        "2:14-2:17",
+        "3:14-3:27",
+        "6:14-6:30",
+        "7:14-7:24",
+        "8:14-8:43",
+        "11:1-11:12",
+        "12:1-12:5",
+        "13:1-13:21",
+    ],
+    rewritten_files: [],
+    created_files: [],
+}

crates/biome_grit_patterns/tests/specs/ts/spreadMetavariable.snap

@@ -0,0 +1,14 @@
+const arr1 = [0, 1, 2];
+const arr2 = [1];
+const arr3 = ["a", 1, "b"];
+const arr4 = [0, 2, 3]; // Should not match
+
+const obj1 = { key: 1, a: 2 };
+const obj2 = { key: 1 };
+const obj3 = { key: 1, x: true, y: false };
+const obj4 = { key: 2, a: 2 }; // Should not match
+
+fn(1, 2, 3);
+fn();
+fn("hello", "world");
+otherFn(1, 2, 3); // Should not match

crates/biome_grit_patterns/tests/specs/ts/spreadMetavariable.ts

@@ -1324,7 +1324,9 @@ fn selector_from_variable_declarator(var: &JsVariableDeclarator, scope: Scope) -
 
 fn selector_from_object_member(member: &AnyJsObjectMember) -> Option<Selector> {
     match member {
-        AnyJsObjectMember::JsBogusMember(_) | AnyJsObjectMember::JsSpread(_) => None,
+        AnyJsObjectMember::JsBogusMember(_)
+        | AnyJsObjectMember::JsSpread(_)
+        | AnyJsObjectMember::JsMetavariable(_) => None,
         AnyJsObjectMember::JsGetterObjectMember(_) => Some(Kind::ObjectLiteralGetter.into()),
         AnyJsObjectMember::JsMethodObjectMember(_) => Some(Kind::ObjectLiteralMethod.into()),
         AnyJsObjectMember::JsPropertyObjectMember(_)

crates/biome_js_analyze/src/lint/style/use_naming_convention.rs

@@ -254,7 +254,9 @@ impl TryFrom<&AnyJsObjectMember> for DefinedProperty {
             AnyJsObjectMember::JsShorthandPropertyObjectMember(member) => {
                 Ok(Self::Property(member.syntax().index() as u32))
             }
-            AnyJsObjectMember::JsBogusMember(_) | AnyJsObjectMember::JsSpread(_) => Err(()),
+            AnyJsObjectMember::JsBogusMember(_)
+            | AnyJsObjectMember::JsSpread(_)
+            | AnyJsObjectMember::JsMetavariable(_) => Err(()),
         }
     }
 }

crates/biome_js_analyze/src/lint/suspicious/no_duplicate_object_keys.rs

@@ -10,6 +10,7 @@ impl FormatRule<AnyJsObjectMember> for FormatAnyJsObjectMember {
         match node {
             AnyJsObjectMember::JsBogusMember(node) => node.format().fmt(f),
             AnyJsObjectMember::JsGetterObjectMember(node) => node.format().fmt(f),
+            AnyJsObjectMember::JsMetavariable(node) => node.format().fmt(f),
             AnyJsObjectMember::JsMethodObjectMember(node) => node.format().fmt(f),
             AnyJsObjectMember::JsPropertyObjectMember(node) => node.format().fmt(f),
             AnyJsObjectMember::JsSetterObjectMember(node) => node.format().fmt(f),

crates/biome_js_formatter/src/js/any/object_member.rs

@@ -89,6 +89,11 @@ pub(super) fn parse_object_expression(p: &mut JsParser) -> ParsedSyntax {
 /// An individual object property such as `"a": b` or `5: 6 + 6`.
 fn parse_object_member(p: &mut JsParser) -> ParsedSyntax {
     match p.cur() {
+        // let a = { key: 1, $... }
+        // `$...` acts as a spread metavariable (matches zero or more remaining members).
+        // A metavariable followed by `:` continues to be parsed as a property key.
+        t if t.is_metavariable() && !p.nth_at(1, T![:]) => parse_metavariable(p),
+
         // test js getter_object_member
         // let a = {
         //   get foo() {

crates/biome_js_parser/src/syntax/object.rs

@@ -1817,7 +1817,7 @@ impl AnyJsObjectMember {
             Self::JsShorthandPropertyObjectMember(member) => {
                 return Some(member.name().ok()?.value_token().ok()?.token_text_trimmed());
             }
-            Self::JsBogusMember(_) | Self::JsSpread(_) => {
+            Self::JsBogusMember(_) | Self::JsSpread(_) | Self::JsMetavariable(_) => {
                 return None;
             }
         };