From baa95d11e837b3ed9606f6778f366f4b81888048 Mon Sep 17 00:00:00 2001 From: tienbku Date: Thu, 26 May 2022 17:51:53 +0700 Subject: [PATCH 01/44] update package --- README.md | 8 +++++++- package.json | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index d754176b..42e9586e 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ For instruction, please visit: Front-end that works well with this Back-end > [Axios Client](https://www.bezkoder.com/axios-request/) -> [Angular 8 Client](https://www.bezkoder.com/angular-crud-app/) / [Angular 10 Client](https://www.bezkoder.com/angular-10-crud-app/) / [Angular 11 Client](https://www.bezkoder.com/angular-11-crud-app/) / [Angular 12 Client](https://www.bezkoder.com/angular-12-crud-app/) / [Angular 13 Client](https://www.bezkoder.com/angular-13-crud-example/) +> [Angular 8 Client](https://www.bezkoder.com/angular-crud-app/) / [Angular 10 Client](https://www.bezkoder.com/angular-10-crud-app/) / [Angular 11 Client](https://www.bezkoder.com/angular-11-crud-app/) / [Angular 12 Client](https://www.bezkoder.com/angular-12-crud-app/) / [Angular 13 Client](https://www.bezkoder.com/angular-13-crud-example/) / [Angular 14 Client](https://www.bezkoder.com/angular-14-crud-example/) / [Angular 15 Client](https://www.bezkoder.com/angular-15-crud-example/) > [Vue 2 Client](https://www.bezkoder.com/vue-js-crud-app/) / [Vue 3 Client](https://www.bezkoder.com/vue-3-crud/) / [Vuetify Client](https://www.bezkoder.com/vuetify-data-table-example/) @@ -48,6 +48,12 @@ Fullstack: > [Angular 12 + Node.js Express + MySQL example](https://www.bezkoder.com/angular-12-node-js-express-mysql/) +> [Angular 13 + Node.js Express + MySQL example](https://www.bezkoder.com/angular-13-node-js-express-mysql/) + +> [Angular 14 + Node.js + Express + MySQL example](https://www.bezkoder.com/angular-14-node-js-express-mysql/) + +> [Angular 15 + Node.js + Express + MySQL example](https://www.bezkoder.com/angular-15-node-js-express-mysql/) + > [React + Node.js + Express + MySQL example](https://www.bezkoder.com/react-node-express-mysql/) > [React + Redux + Node.js Express + MySQL](https://www.bezkoder.com/react-redux-mysql-crud/) diff --git a/package.json b/package.json index ef1deac0..e0a3e025 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "license": "ISC", "dependencies": { "cors": "^2.8.5", - "express": "^4.17.1", - "mysql": "^2.17.1" + "express": "^4.18.1", + "mysql": "^2.18.1" } } From e2f4d4e2a6469d90f9494e5508d9396fbc28e24a Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Wed, 15 Mar 2023 15:57:14 +0530 Subject: [PATCH 02/44] implementing synk pipeline --- .github/workflows | 20 ++++++++++++++++++++ package.json | 6 +++--- 2 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 .github/workflows diff --git a/.github/workflows b/.github/workflows new file mode 100644 index 00000000..26ef6ace --- /dev/null +++ b/.github/workflows @@ -0,0 +1,20 @@ +name: Snyk Scan + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +jobs: + snyk: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Install Snyk + run: npm install -g snyk + - name: Snyk scan + run: snyk auth $SNYK_TOKEN && snyk test + env: + SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} diff --git a/package.json b/package.json index e0a3e025..87ca9fde 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,8 @@ "author": "bezkoder", "license": "ISC", "dependencies": { - "cors": "^2.8.5", - "express": "^4.18.1", - "mysql": "^2.18.1" + "cors": "2.8.5", + "express": "4.18.1", + "mysql": "2.18.1" } } From 8bcf20181357e84134f7ee1bf8222d8a97746c79 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Wed, 15 Mar 2023 16:02:50 +0530 Subject: [PATCH 03/44] adding yaml file --- .github/{workflows => workflows/synk.yaml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/{workflows => workflows/synk.yaml} (88%) diff --git a/.github/workflows b/.github/workflows/synk.yaml similarity index 88% rename from .github/workflows rename to .github/workflows/synk.yaml index 26ef6ace..8196edb0 100644 --- a/.github/workflows +++ b/.github/workflows/synk.yaml @@ -17,4 +17,4 @@ jobs: - name: Snyk scan run: snyk auth $SNYK_TOKEN && snyk test env: - SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} + SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} \ No newline at end of file From eb02e75d2e661bb9e8c60ef4047d248d87bdb5b8 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 10:10:41 +0530 Subject: [PATCH 04/44] installation of node step added --- .github/workflows/synk.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 8196edb0..9fb710bc 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -16,5 +16,7 @@ jobs: run: npm install -g snyk - name: Snyk scan run: snyk auth $SNYK_TOKEN && snyk test + - name: node updations + run: npm install env: SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} \ No newline at end of file From d3f4c5a2d613ad98824cf39f887196ff440fbb26 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Thu, 16 Mar 2023 05:04:55 +0000 Subject: [PATCH 05/44] fix: upgrade express from 4.18.1 to 4.18.2 Snyk has created this PR to upgrade express from 4.18.1 to 4.18.2. See this package in npm: https://www.npmjs.com/package/express See this project in Snyk: https://app.snyk.io/org/abhi-moreyeahs/project/ee87fc1d-7318-4d19-a36f-cb4ee1048c9b?utm_source=github&utm_medium=referral&page=upgrade-pr --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 87ca9fde..7813864c 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "license": "ISC", "dependencies": { "cors": "2.8.5", - "express": "4.18.1", + "express": "4.18.2", "mysql": "2.18.1" } } From 48f740cff1e2f4d98fe2daac98b8cd13e1ab90fb Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 10:51:41 +0530 Subject: [PATCH 06/44] changes for secrets --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 9fb710bc..ed203923 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -15,7 +15,7 @@ jobs: - name: Install Snyk run: npm install -g snyk - name: Snyk scan - run: snyk auth $SNYK_TOKEN && snyk test + run: snyk auth $secrets.SNYK_TOKEN && snyk test - name: node updations run: npm install env: From 0da53df8157a150fa222053c3be7d47198ccdf7b Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 10:54:48 +0530 Subject: [PATCH 07/44] changes for secrets --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index ed203923..a63b1338 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -16,7 +16,7 @@ jobs: run: npm install -g snyk - name: Snyk scan run: snyk auth $secrets.SNYK_TOKEN && snyk test - - name: node updations + - name: node module updations run: npm install env: SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} \ No newline at end of file From f4a843e731fca615adf7659537fef9c7ea921759 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 11:09:48 +0530 Subject: [PATCH 08/44] changes for secrets --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index a63b1338..24fa3487 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -15,7 +15,7 @@ jobs: - name: Install Snyk run: npm install -g snyk - name: Snyk scan - run: snyk auth $secrets.SNYK_TOKEN && snyk test + run: snyk auth $SNYK_TOKEN && snyk test - name: node module updations run: npm install env: From ce8076f5f67c1bf69b295dc819baaa17f5e5cb28 Mon Sep 17 00:00:00 2001 From: "abhishek.kumar@gmail.com" Date: Thu, 16 Mar 2023 16:51:36 +0530 Subject: [PATCH 09/44] final commit --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 24fa3487..afbbba2b 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout codess uses: actions/checkout@v2 - name: Install Snyk run: npm install -g snyk From b7b967351a46cd304de25c0b31c56b13795a8374 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:01:49 +0530 Subject: [PATCH 10/44] not final commit --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index afbbba2b..53868f90 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout codess + - name: Checkout codes uses: actions/checkout@v2 - name: Install Snyk run: npm install -g snyk From 74902d74355a0e56a5100f644ec256aa8895720a Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:13:31 +0530 Subject: [PATCH 11/44] one --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 53868f90..24fa3487 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout codes + - name: Checkout code uses: actions/checkout@v2 - name: Install Snyk run: npm install -g snyk From 35b49e4c43014eecedcb2c8ef82964d2ff64d463 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:21:15 +0530 Subject: [PATCH 12/44] new change --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 24fa3487..53868f90 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout codes uses: actions/checkout@v2 - name: Install Snyk run: npm install -g snyk From 0e6a9e4b13f2da3f81e11b57807348eca63da9a7 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:23:58 +0530 Subject: [PATCH 13/44] few changes done --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 53868f90..24fa3487 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout codes + - name: Checkout code uses: actions/checkout@v2 - name: Install Snyk run: npm install -g snyk From e5baf0eb1a65c408a0158aa4a6779930a32fc560 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:25:51 +0530 Subject: [PATCH 14/44] hard cotted api token --- .github/workflows/synk.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 24fa3487..3f6abfbb 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -15,8 +15,8 @@ jobs: - name: Install Snyk run: npm install -g snyk - name: Snyk scan - run: snyk auth $SNYK_TOKEN && snyk test + run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e && snyk test - name: node module updations run: npm install env: - SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} \ No newline at end of file + SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file From 6740f9d9d9ad8a0cac01028aa81dc1cab8056aa3 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:28:04 +0530 Subject: [PATCH 15/44] few changes done --- .github/workflows/synk.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 3f6abfbb..733a9efd 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -15,7 +15,11 @@ jobs: - name: Install Snyk run: npm install -g snyk - name: Snyk scan - run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e && snyk test + run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e + - name: npm installation + run: npm install + - name: Snyk testing + run: snyk test - name: node module updations run: npm install env: From 710094283aae7fdbc887d4b7384178f1a2b79681 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:29:10 +0530 Subject: [PATCH 16/44] few changes done --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 733a9efd..af0919e9 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -19,7 +19,7 @@ jobs: - name: npm installation run: npm install - name: Snyk testing - run: snyk test + run: snyk test && npm install - name: node module updations run: npm install env: From fd665a571acfe44140d3047f645e017a7c14f73d Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:31:18 +0530 Subject: [PATCH 17/44] few changes done --- .github/workflows/synk.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index af0919e9..0515c110 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -17,9 +17,9 @@ jobs: - name: Snyk scan run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e - name: npm installation - run: npm install + run: npm install --package-lock-only - name: Snyk testing - run: snyk test && npm install + run: snyk test && npm install --package-lock-only - name: node module updations run: npm install env: From 9bf41c35ba06aacce3e066283f0f8a30115251d5 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 16 Mar 2023 17:38:48 +0530 Subject: [PATCH 18/44] hard cotted api token --- .github/workflows/synk.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 0515c110..1dae1c50 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -17,10 +17,8 @@ jobs: - name: Snyk scan run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e - name: npm installation - run: npm install --package-lock-only + run: npm install --strict-out-of-sync=false - name: Snyk testing - run: snyk test && npm install --package-lock-only - - name: node module updations - run: npm install + run: snyk test && npm install --strict-out-of-sync=false env: SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file From 0d53b30de18c89f4f16b3873768fc41e3306bfc7 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 17 Mar 2023 10:36:26 +0530 Subject: [PATCH 19/44] The Final Commit --- .github/workflows/synk.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 1dae1c50..87887e6a 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -12,13 +12,13 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v2 - - name: Install Snyk + - name: Install Snyk open-source tool run: npm install -g snyk - - name: Snyk scan + - name: Snyk scanning process run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e - name: npm installation run: npm install --strict-out-of-sync=false - name: Snyk testing - run: snyk test && npm install --strict-out-of-sync=false + run: snyk test --strict-out-of-sync=false env: SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file From 75ea3eab30b26d3db27d627272702b53072a0857 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 17 Mar 2023 10:38:46 +0530 Subject: [PATCH 20/44] The Final Commit --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 87887e6a..96d333d7 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout Code uses: actions/checkout@v2 - name: Install Snyk open-source tool run: npm install -g snyk From 3d7788c88bb1f60378164f854c59053991bd40e4 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 17 Mar 2023 10:41:39 +0530 Subject: [PATCH 21/44] The Final Commit --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 96d333d7..87887e6a 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout Code + - name: Checkout code uses: actions/checkout@v2 - name: Install Snyk open-source tool run: npm install -g snyk From af3a7d428010834bc1fe252b6f62712e63d67a06 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 17 Mar 2023 12:17:50 +0530 Subject: [PATCH 22/44] demo --- .github/workflows/synk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 87887e6a..7a257d23 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout codes uses: actions/checkout@v2 - name: Install Snyk open-source tool run: npm install -g snyk From 6b44f77ceb884c162140ea5cb3d1efa9228aefa9 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 17 Mar 2023 15:15:36 +0530 Subject: [PATCH 23/44] Demo Testing --- .github/workflows/synk.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/synk.yaml b/.github/workflows/synk.yaml index 7a257d23..b3022887 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/synk.yaml @@ -1,4 +1,4 @@ -name: Snyk Scan +name: Snyk Scan for mysql-express node project on: push: @@ -10,7 +10,7 @@ jobs: snyk: runs-on: ubuntu-latest steps: - - name: Checkout codes + - name: Checkout code uses: actions/checkout@v2 - name: Install Snyk open-source tool run: npm install -g snyk From f1933b86df26609ceff5cd846f09db73d4edde5a Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 23 Mar 2023 11:12:58 +0530 Subject: [PATCH 24/44] demo scan synk --- .github/workflows/{synk.yaml => snyk.yaml} | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) rename .github/workflows/{synk.yaml => snyk.yaml} (51%) diff --git a/.github/workflows/synk.yaml b/.github/workflows/snyk.yaml similarity index 51% rename from .github/workflows/synk.yaml rename to .github/workflows/snyk.yaml index b3022887..bee5d4a3 100644 --- a/.github/workflows/synk.yaml +++ b/.github/workflows/snyk.yaml @@ -1,3 +1,24 @@ +# name: Sonar Scan +# on: +# push: +# branches: +# - master +# pull_request: +# types: [opened, synchronize, reopened] +# jobs: +# sonarcloud: +# name: SonarCloud +# runs-on: ubuntu-latest +# steps: +# - uses: actions/checkout@v2 +# with: +# fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis +# - name: SonarCloud Scan +# uses: SonarSource/sonarcloud-github-action@master +# env: +# # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any +# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + name: Snyk Scan for mysql-express node project on: From 1b6d1ad7b638d25deef677bac729f7b6090cf04b Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 23 Mar 2023 11:35:08 +0530 Subject: [PATCH 25/44] demo for sonarscanner --- .github/workflows/snyk.yaml | 76 ++++++++++++++++++------------------- sonar-project.properties | 18 +++++++++ 2 files changed, 56 insertions(+), 38 deletions(-) create mode 100644 sonar-project.properties diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index bee5d4a3..a63f43bb 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -1,45 +1,45 @@ -# name: Sonar Scan -# on: -# push: -# branches: -# - master -# pull_request: -# types: [opened, synchronize, reopened] -# jobs: -# sonarcloud: -# name: SonarCloud -# runs-on: ubuntu-latest -# steps: -# - uses: actions/checkout@v2 -# with: -# fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis -# - name: SonarCloud Scan -# uses: SonarSource/sonarcloud-github-action@master -# env: -# # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any -# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - -name: Snyk Scan for mysql-express node project - +name: Sonar Scan on: push: - branches: [ master ] + branches: + - master pull_request: - branches: [ master ] - + types: [opened, synchronize, reopened] jobs: - snyk: + sonarcloud: + name: SonarCloud runs-on: ubuntu-latest steps: - - name: Checkout code - uses: actions/checkout@v2 - - name: Install Snyk open-source tool - run: npm install -g snyk - - name: Snyk scanning process - run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e - - name: npm installation - run: npm install --strict-out-of-sync=false - - name: Snyk testing - run: snyk test --strict-out-of-sync=false + - uses: actions/checkout@v2 + with: + fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis + - name: SonarCloud Scan + uses: SonarSource/sonarcloud-github-action@master env: - SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + +# name: Snyk Scan for mysql-express node project + +# on: +# push: +# branches: [ master ] +# pull_request: +# branches: [ master ] + +# jobs: +# snyk: +# runs-on: ubuntu-latest +# steps: +# - name: Checkout code +# uses: actions/checkout@v2 +# - name: Install Snyk open-source tool +# run: npm install -g snyk +# - name: Snyk scanning process +# run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e +# - name: npm installation +# run: npm install --strict-out-of-sync=false +# - name: Snyk testing +# run: snyk test --strict-out-of-sync=false +# env: +# SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file diff --git a/sonar-project.properties b/sonar-project.properties new file mode 100644 index 00000000..f9981f66 --- /dev/null +++ b/sonar-project.properties @@ -0,0 +1,18 @@ +# required metdata +sonar.projectKey=Abhi-Moreyeahs_nodejs-express-mysql +sonar.organization=abhi-moreyeahs +sonar.projectVersion=1.0 +sonar.sourceEncoding=UTF-8 +# sonar.language=js +sonar.eslint.eslintconfigpath=app/eslintrc.json + +# path to srouce directories +sonar.sources=app +# sonar.tests=app/test/integration/api/ + +# excludes +sonar.exclusions=app/node_modules/*,app/coverage/lcov-report/*,app/test/integration/api/v1/*,app/middlewares/common-middleware.js + +# coverage reporting +sonar.javascript.lcov.reportPaths=app/coverage/lcov.info +# sonar.surefire.reportPaths=app/coverage/lcov-report \ No newline at end of file From a3f292d5e4601fd1b203ed5fe042cac8f8dba9e2 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 23 Mar 2023 11:40:21 +0530 Subject: [PATCH 26/44] deleted package.json file --- package.json | 22 ---------------------- 1 file changed, 22 deletions(-) delete mode 100644 package.json diff --git a/package.json b/package.json deleted file mode 100644 index 7813864c..00000000 --- a/package.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "name": "nodejs-express-mysql", - "version": "1.0.0", - "description": "Node.js Restful CRUD API with Node.js, Express and MySQL", - "main": "server.js", - "scripts": { - "test": "echo \"Error: no test specified\" && exit 1" - }, - "keywords": [ - "nodejs", - "express", - "mysql", - "restapi" - ], - "author": "bezkoder", - "license": "ISC", - "dependencies": { - "cors": "2.8.5", - "express": "4.18.2", - "mysql": "2.18.1" - } -} From 846087bfe5b0c01a7a735ca5a536e571b71797cf Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 23 Mar 2023 11:42:46 +0530 Subject: [PATCH 27/44] disable automatic CI analysis --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index a63f43bb..d098843b 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v2 with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - - name: SonarCloud Scan + - name: SonarCloud Scaning uses: SonarSource/sonarcloud-github-action@master env: # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any From c20c81d37008c20c93728c0f5268f81998715756 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Thu, 23 Mar 2023 11:45:07 +0530 Subject: [PATCH 28/44] added package.json filr again --- package.json | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package.json diff --git a/package.json b/package.json new file mode 100644 index 00000000..f45d4fa4 --- /dev/null +++ b/package.json @@ -0,0 +1,23 @@ +{ + "name": "nodejs-express-mysql", + "version": "1.0.0", + "description": "Node.js Restful CRUD API with Node.js, Express and MySQL", + "main": "server.js", + "scripts": { + "test": "echo \"Error: no test specified\" && exit 1" + }, + "keywords": [ + "nodejs", + "express", + "mysql", + "restapi" + ], + "author": "bezkoder", + "license": "ISC", + "dependencies": { + "cors": "2.8.5", + "express": "4.18.2", + "mysql": "2.18.1" + } + } + \ No newline at end of file From f84545aa72bcef58a4998f8395836debacf1d33c Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 24 Mar 2023 11:21:53 +0530 Subject: [PATCH 29/44] Test --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index d098843b..ae64523d 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v2 with: fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - - name: SonarCloud Scaning + - name: SonarCloud Scaning Process uses: SonarSource/sonarcloud-github-action@master env: # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any From 015daf79b9ddffad46062cfc0eeeb72ffde12032 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs Date: Fri, 24 Mar 2023 11:26:23 +0530 Subject: [PATCH 30/44] Test snyk Scanner --- .github/workflows/snyk.yaml | 76 ++++++++++++++++++------------------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index ae64523d..60942544 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -1,45 +1,45 @@ -name: Sonar Scan -on: - push: - branches: - - master - pull_request: - types: [opened, synchronize, reopened] -jobs: - sonarcloud: - name: SonarCloud - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - with: - fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis - - name: SonarCloud Scaning Process - uses: SonarSource/sonarcloud-github-action@master - env: - # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - -# name: Snyk Scan for mysql-express node project - +# name: Sonar Scan # on: # push: -# branches: [ master ] +# branches: +# - master # pull_request: -# branches: [ master ] - +# types: [opened, synchronize, reopened] # jobs: -# snyk: +# sonarcloud: +# name: SonarCloud # runs-on: ubuntu-latest # steps: -# - name: Checkout code -# uses: actions/checkout@v2 -# - name: Install Snyk open-source tool -# run: npm install -g snyk -# - name: Snyk scanning process -# run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e -# - name: npm installation -# run: npm install --strict-out-of-sync=false -# - name: Snyk testing -# run: snyk test --strict-out-of-sync=false +# - uses: actions/checkout@v2 +# with: +# fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis +# - name: SonarCloud Scaning Process +# uses: SonarSource/sonarcloud-github-action@master # env: -# SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file +# # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any +# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + +name: Snyk Scan for mysql-express node project + +on: + push: + branches: [ master ] + pull_request: + branches: [ master ] + +jobs: + snyk: + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v2 + - name: Install Snyk open-source tool + run: npm install -g snyk + - name: Snyk scanning process + run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e + - name: npm installation + run: npm install --strict-out-of-sync=false + - name: Snyk testing + run: snyk test --strict-out-of-sync=false + env: + SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file From b3900fe3974124982b92ea56c9e5a50e07584838 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 15:54:32 +0530 Subject: [PATCH 31/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 71 +++++++++++++++---------------------- 1 file changed, 28 insertions(+), 43 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 60942544..ac023291 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -1,45 +1,30 @@ -# name: Sonar Scan -# on: -# push: -# branches: -# - master -# pull_request: -# types: [opened, synchronize, reopened] -# jobs: -# sonarcloud: -# name: SonarCloud -# runs-on: ubuntu-latest -# steps: -# - uses: actions/checkout@v2 -# with: -# fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis -# - name: SonarCloud Scaning Process -# uses: SonarSource/sonarcloud-github-action@master -# env: -# # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any -# SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + name: Sonar Scan + on: + push: + branches: + - master + jobs: + sonarcloud: + name: SonarCloud Scan and Quality Gate + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 -name: Snyk Scan for mysql-express node project + - name: SonarCloud Scaning Process + uses: SonarSource/sonarcloud-github-action@v1.3 + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + + - name: Wait for Quality Gate Approval + id: quality-gate + uses: peaceiris/actions-approval@v2 + with: + message: 'Please review the SonarCloud Quality Gate report' + reviewers: "" + + - name: Check Quality Gate Status + if: steps.quality-gate.outputs.approved == 'true' + run: echo 'Quality Gate passed!' -on: - push: - branches: [ master ] - pull_request: - branches: [ master ] - -jobs: - snyk: - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v2 - - name: Install Snyk open-source tool - run: npm install -g snyk - - name: Snyk scanning process - run: snyk auth ce1d4d14-9e9b-4caa-91dc-b904b253891e - - name: npm installation - run: npm install --strict-out-of-sync=false - - name: Snyk testing - run: snyk test --strict-out-of-sync=false - env: - SNYK_TOKEN: ${{ secrets.ce1d4d14-9e9b-4caa-91dc-b904b253891e }} \ No newline at end of file From 34df7f821e6a82adecf5c10dd17889f0225e9cc9 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:00:32 +0530 Subject: [PATCH 32/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index ac023291..bdd20e12 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -3,14 +3,18 @@ push: branches: - master + pull_request: + types: [opened, synchronize, reopened] + jobs: sonarcloud: name: SonarCloud Scan and Quality Gate runs-on: ubuntu-latest steps: - - name: Checkout code - uses: actions/checkout@v2 + - uses: actions/checkout@v2 + with: + fetch-depth: 0 - name: SonarCloud Scaning Process uses: SonarSource/sonarcloud-github-action@v1.3 From 309c209d89f7cf7f03b90f8e41bd8fcc11f54d2d Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:16:49 +0530 Subject: [PATCH 33/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index bdd20e12..07b6b12f 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -21,14 +21,21 @@ env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - - name: Wait for Quality Gate Approval - id: quality-gate - uses: peaceiris/actions-approval@v2 - with: - message: 'Please review the SonarCloud Quality Gate report' - reviewers: "" - - - name: Check Quality Gate Status - if: steps.quality-gate.outputs.approved == 'true' - run: echo 'Quality Gate passed!' + approval: + runs-on: ubuntu-latest + + steps: + - name: Review request + uses: trstringer/manual-approval@v1 + with: + secret: ${{ secrets.SONAR_TOKEN }} + approvers: Abhi-Moreyeahs + minimum-approvals: 1 + issue-title: "Sonar CLoud Scanning Process" + issue-body: "Please approve or deny the Sccaned Quality gate" + exclude-workflow-initiator-as-approver: false + additional-approved-words: 'Accepted' + additional-denied-words: 'Rejected' + + From 9d7b3e2d280564947b8e836bde0aeeab92547cb5 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:20:44 +0530 Subject: [PATCH 34/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 07b6b12f..e9fa8b3b 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -17,7 +17,7 @@ fetch-depth: 0 - name: SonarCloud Scaning Process - uses: SonarSource/sonarcloud-github-action@v1.3 + uses: SonarSource/sonarcloud-github-action@master env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} From be2110409f2c2d7ad5dabaee9fe83bf7db5e28c5 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:36:54 +0530 Subject: [PATCH 35/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index e9fa8b3b..958e4920 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -28,7 +28,7 @@ - name: Review request uses: trstringer/manual-approval@v1 with: - secret: ${{ secrets.SONAR_TOKEN }} + secret: ${{ secrets.GT_TOKEN }} approvers: Abhi-Moreyeahs minimum-approvals: 1 issue-title: "Sonar CLoud Scanning Process" From c168f2517805854d400dd20e1aa404f32cd4bcb2 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:43:33 +0530 Subject: [PATCH 36/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 958e4920..2db2de06 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -33,7 +33,6 @@ minimum-approvals: 1 issue-title: "Sonar CLoud Scanning Process" issue-body: "Please approve or deny the Sccaned Quality gate" - exclude-workflow-initiator-as-approver: false additional-approved-words: 'Accepted' additional-denied-words: 'Rejected' From d3c36378368cafc56e4667b0fc8ac4ad191da7ac Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:54:44 +0530 Subject: [PATCH 37/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 2db2de06..d94c0e0c 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -25,16 +25,15 @@ runs-on: ubuntu-latest steps: - - name: Review request - uses: trstringer/manual-approval@v1 + - name: Request approval + uses: peter-evans/create-pull-request-review@v1 with: - secret: ${{ secrets.GT_TOKEN }} - approvers: Abhi-Moreyeahs - minimum-approvals: 1 - issue-title: "Sonar CLoud Scanning Process" - issue-body: "Please approve or deny the Sccaned Quality gate" - additional-approved-words: 'Accepted' - additional-denied-words: 'Rejected' + github-token: ${{ secrets.GT_TOKEN }} + reviewers: Abhi-Moreyeahs, drashinkar + team-reviewers: Abhi-Moreyeahs, drashinkar + message: Please review the code changes and approve or request changes. + additional-approved-words: 'Accepted' + additional-denied-words: 'Rejected' From 24e157e319ad8e54f11974b5f1fc0d8f7bb4327c Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:56:10 +0530 Subject: [PATCH 38/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index d94c0e0c..2894c6a9 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -26,7 +26,7 @@ steps: - name: Request approval - uses: peter-evans/create-pull-request-review@v1 + uses: pullreminders/request-review-action@v1 with: github-token: ${{ secrets.GT_TOKEN }} reviewers: Abhi-Moreyeahs, drashinkar From 31b0abcc1e9a272b3f4243b5a831a335320abeb2 Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:57:29 +0530 Subject: [PATCH 39/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 2894c6a9..6419c49f 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -26,7 +26,7 @@ steps: - name: Request approval - uses: pullreminders/request-review-action@v1 + uses: trstringer/manual-approval@v1 with: github-token: ${{ secrets.GT_TOKEN }} reviewers: Abhi-Moreyeahs, drashinkar From 309e302a5ce4d0cd11a09ae8cd54a9ca08ee75bd Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:58:17 +0530 Subject: [PATCH 40/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 6419c49f..113f69fb 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -29,11 +29,9 @@ uses: trstringer/manual-approval@v1 with: github-token: ${{ secrets.GT_TOKEN }} - reviewers: Abhi-Moreyeahs, drashinkar + reviewers: Abhi-Moreyeahs team-reviewers: Abhi-Moreyeahs, drashinkar message: Please review the code changes and approve or request changes. - additional-approved-words: 'Accepted' - additional-denied-words: 'Rejected' From 6fcdbf705428b79c6c947f1e6a1bf76e815cae4f Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 16:59:43 +0530 Subject: [PATCH 41/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 113f69fb..3db0e6d4 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -21,17 +21,14 @@ env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - approval: - runs-on: ubuntu-latest - - steps: - - name: Request approval - uses: trstringer/manual-approval@v1 - with: - github-token: ${{ secrets.GT_TOKEN }} - reviewers: Abhi-Moreyeahs - team-reviewers: Abhi-Moreyeahs, drashinkar - message: Please review the code changes and approve or request changes. + - name: Request approval + uses: trstringer/manual-approval@v1 + with: + github-token: ${{ secrets.GT_TOKEN }} + reviewers: Abhi-Moreyeahs + team-reviewers: Abhi-Moreyeahs + message: Please review the code changes and approve or request changes. + From feee8999a9adb5eb42ce720abfd04631c1be490a Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Thu, 20 Apr 2023 17:04:41 +0530 Subject: [PATCH 42/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 3db0e6d4..19efec0a 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -24,7 +24,7 @@ - name: Request approval uses: trstringer/manual-approval@v1 with: - github-token: ${{ secrets.GT_TOKEN }} + github-token: ${{ secrets.GT_token }} reviewers: Abhi-Moreyeahs team-reviewers: Abhi-Moreyeahs message: Please review the code changes and approve or request changes. From bb6aee64e7dd700a2f1396ce70618ab21d2c85d4 Mon Sep 17 00:00:00 2001 From: drashinkar <96113406+drashinkar@users.noreply.github.com> Date: Thu, 20 Apr 2023 17:11:28 +0530 Subject: [PATCH 43/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index 19efec0a..c31d74b3 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -21,13 +21,11 @@ env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - - name: Request approval + - name: approval uses: trstringer/manual-approval@v1 with: - github-token: ${{ secrets.GT_token }} - reviewers: Abhi-Moreyeahs - team-reviewers: Abhi-Moreyeahs - message: Please review the code changes and approve or request changes. + secret: ${{ secrets.GT_TOKEN }} + approvers: Abhi-Moreyeahs From 602c1aabf702f91e41c3885336a6445f7d4048c7 Mon Sep 17 00:00:00 2001 From: Abhi-Moreyeahs <127124862+Abhi-Moreyeahs@users.noreply.github.com> Date: Wed, 31 May 2023 13:54:03 +0530 Subject: [PATCH 44/44] Update snyk.yaml --- .github/workflows/snyk.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/snyk.yaml b/.github/workflows/snyk.yaml index c31d74b3..0e2dd7aa 100644 --- a/.github/workflows/snyk.yaml +++ b/.github/workflows/snyk.yaml @@ -21,11 +21,11 @@ env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - - name: approval - uses: trstringer/manual-approval@v1 - with: - secret: ${{ secrets.GT_TOKEN }} - approvers: Abhi-Moreyeahs + #- name: approval + # uses: trstringer/manual-approval@v1 + # with: + # secret: ${{ secrets.GT_TOKEN }} + # approvers: Abhi-Moreyeahs