Skip to content

Commit 2a2bba7

Browse files
author
Ben Roling
committed
Clarify log message
1 parent 6e62a3a commit 2a2bba7

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/ChangeTracker.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class ChangeTracker {
5454
private static final Logger LOG =
5555
LoggerFactory.getLogger(ChangeTracker.class);
5656

57-
public static final String CHANGE_REPORTED_BY_S3 = "reported by S3";
57+
public static final String CHANGE_REPORTED_BY_S3 = "Change reported by S3";
5858

5959
/** Policy to use. */
6060
private final ChangeDetectionPolicy policy;
@@ -164,13 +164,12 @@ public void processResponse(final S3Object object,
164164
// object was not returned.
165165
versionMismatches.incrementAndGet();
166166
throw new RemoteFileChangedException(uri, operation,
167-
String.format("%s change "
168-
+ CHANGE_REPORTED_BY_S3
167+
String.format(CHANGE_REPORTED_BY_S3
169168
+ " while reading"
170169
+ " at position %s."
171-
+ " Version %s was unavailable",
172-
getSource(),
170+
+ " %s %s was unavailable",
173171
pos,
172+
getSource(),
174173
getRevisionId()));
175174
} else {
176175
throw new PathIOException(uri, "No data returned from GET request");

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/s3guard.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,8 +1136,8 @@ the file.
11361136

11371137
```
11381138
org.apache.hadoop.fs.s3a.RemoteFileChangedException: open 's3a://my-bucket/test/file.txt':
1139-
ETag change reported by S3 while reading at position 0.
1140-
Version 4e886e26c072fef250cfaf8037675405 was unavailable
1139+
Change reported by S3 while reading at position 0.
1140+
ETag 4e886e26c072fef250cfaf8037675405 was unavailable
11411141
at org.apache.hadoop.fs.s3a.impl.ChangeTracker.processResponse(ChangeTracker.java:167)
11421142
at org.apache.hadoop.fs.s3a.S3AInputStream.reopen(S3AInputStream.java:207)
11431143
at org.apache.hadoop.fs.s3a.S3AInputStream.lambda$lazySeek$1(S3AInputStream.java:355)

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -970,8 +970,8 @@ and the like. The standard strategy here is to save to HDFS and then copy to S3.
970970

971971
```
972972
org.apache.hadoop.fs.s3a.RemoteFileChangedException: re-open `s3a://my-bucket/test/file.txt':
973-
ETag change reported by S3 while reading at position 1949.
974-
Version f9c186d787d4de9657e99f280ba26555 was unavailable
973+
Change reported by S3 while reading at position 1949.
974+
ETag f9c186d787d4de9657e99f280ba26555 was unavailable
975975
at org.apache.hadoop.fs.s3a.impl.ChangeTracker.processResponse(ChangeTracker.java:137)
976976
at org.apache.hadoop.fs.s3a.S3AInputStream.reopen(S3AInputStream.java:200)
977977
at org.apache.hadoop.fs.s3a.S3AInputStream.lambda$lazySeek$1(S3AInputStream.java:346)

0 commit comments

Comments
 (0)