Skip to content

Commit 2c8f7f4

Browse files
hvadehrarules_java Copybara
authored andcommitted
Strip bzl visibility in rules_java on export
PiperOrigin-RevId: 682229230 Change-Id: I8d71c8880b91ecf84f5e628d4108ccfa005e96e3
1 parent 3cdce96 commit 2c8f7f4

22 files changed

+17
-30
lines changed

java/bazel/rules/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,7 @@ filegroup(
2222
bzl_library(
2323
name = "rules",
2424
srcs = glob(["*.bzl"]),
25-
visibility = [
26-
"//java:__pkg__",
27-
"//java/docs:__pkg__",
28-
],
25+
visibility = ["//visibility:public"], # for Bazel docgen
2926
deps = [
3027
"//java/common",
3128
"//java/common/rules:core_rules",

java/bazel/rules/bazel_java_binary.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ load("//java/common/rules/impl:java_binary_deploy_jar.bzl", "create_deploy_archi
2727
load("//java/common/rules/impl:java_binary_impl.bzl", "basic_java_binary")
2828
load("//java/common/rules/impl:java_helper.bzl", "helper")
2929

30-
visibility("//java/docs")
31-
3230
def _bazel_java_binary_impl(ctx):
3331
return bazel_base_binary_impl(ctx, is_test_rule_class = False) + helper.executable_providers(ctx)
3432

java/bazel/rules/bazel_java_import.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ load("//java/common:java_semantics.bzl", "semantics")
2121
load("//java/common/rules:java_import.bzl", "JAVA_IMPORT_ATTRS")
2222
load("//java/common/rules/impl:bazel_java_import_impl.bzl", "bazel_java_import_rule")
2323

24-
visibility(["//java", "//java/docs"])
25-
2624
def _proxy(ctx):
2725
return bazel_java_import_rule(
2826
ctx,

java/bazel/rules/bazel_java_library.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ load("//java/common/rules:android_lint.bzl", "android_lint_subrule")
2222
load("//java/common/rules:java_library.bzl", "JAVA_LIBRARY_ATTRS")
2323
load("//java/common/rules/impl:bazel_java_library_impl.bzl", "bazel_java_library_rule")
2424

25-
visibility(["//java/..."])
26-
2725
def _proxy(ctx):
2826
return bazel_java_library_rule(
2927
ctx,

java/bazel/rules/bazel_java_plugin.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ load("//java/common/rules:java_plugin.bzl", "JAVA_PLUGIN_ATTRS")
2424
load("//java/common/rules:rule_util.bzl", "merge_attrs")
2525
load("//java/common/rules/impl:basic_java_library_impl.bzl", "basic_java_library", "construct_defaultinfo")
2626

27-
visibility(["//java/..."])
28-
2927
def bazel_java_plugin_rule(
3028
ctx,
3129
srcs = [],

java/bazel/rules/bazel_java_test.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ load("//java/common/rules:rule_util.bzl", "merge_attrs")
1919
load("//java/common/rules/impl:java_helper.bzl", "helper")
2020
load(":bazel_java_binary.bzl", "BASE_BINARY_ATTRS", "bazel_base_binary_impl", "make_binary_rule")
2121

22-
visibility(["//java", "//java/docs"])
23-
2422
def _bazel_java_test_impl(ctx):
2523
return bazel_base_binary_impl(ctx, is_test_rule_class = True) + helper.test_providers(ctx)
2624

java/common/java_semantics.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
load("@rules_cc//cc/common:cc_helper.bzl", "cc_helper")
1717

18-
visibility(["//java/..."])
18+
# copybara: default visibility
1919

2020
def _find_java_toolchain(ctx):
2121
return ctx.toolchains["@bazel_tools//tools/jdk:toolchain_type"].java

java/common/rules/android_lint.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
load("//java/common:java_semantics.bzl", "semantics", _semantics_tokenize_javacopts = "tokenize_javacopts")
1818

19-
visibility(["//java/..."])
19+
# copybara: default visibility
2020

2121
def _tokenize_opts(opts_depset):
2222
opts = reversed(opts_depset.to_list())

java/common/rules/impl/bazel_java_import_impl.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ load("//java/common/rules/impl:basic_java_library_impl.bzl", "construct_defaulti
2424
load("//java/common/rules/impl:import_deps_check.bzl", "import_deps_check")
2525
load(":proguard_validation.bzl", "validate_proguard_specs")
2626

27-
visibility(["//java/..."])
27+
# copybara: default visibility
2828

2929
_java_common_internal = java_common.internal_DO_NOT_USE()
3030
_run_ijar_private_for_builtins = _java_common_internal.run_ijar_private_for_builtins

java/common/rules/impl/bazel_java_library_impl.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Definition of java_library rule.
1818

1919
load("//java/common/rules/impl:basic_java_library_impl.bzl", "basic_java_library", "construct_defaultinfo")
2020

21-
visibility(["//java/..."])
21+
# copybara: default visibility
2222

2323
def bazel_java_library_rule(
2424
ctx,

0 commit comments

Comments
 (0)