Add Java 24 compatibility

The SecurityManager is a hollow shell that just throws exceptions in
Java 24. We should avoid calling it. This will make tests that call
System.exit crash the worker.

Bazel is doing the same thing for now, see
bazelbuild/bazel#24354

It is often possible to edit code to avoid calling System.exit, and guarding
against it requires more effort in Java 24+, likely involving attaching
an agent. Until someone actually has that need, it doesn't seem worth doing.

Author: srdo-humio

scala/private/rule_impls.bzl

@@ -222,11 +222,12 @@ def java_bin_windows(ctx):
 def is_windows(ctx):
     return ctx.configuration.host_path_separator == ";"
 
-# Return a jvm flag allowing security manager for jdk runtime >= 17
+# Return a jvm flag allowing security manager for jdk runtime >= 17 and < 24,
+# since 17 requires explicitly enabling the SM while 24 removes support for the SM entirely.
 # If no runtime is supplied then runtime is taken from ctx.attr._java_host_runtime
 # This must be a runtime used in generated java_binary script (usually workers using SecurityManager)
 def allow_security_manager(ctx, runtime = None):
     java_runtime = runtime if runtime else ctx.attr._java_host_runtime[java_common.JavaRuntimeInfo]
 
     # Bazel 5.x doesn't have java_runtime.version defined
-    return ["-Djava.security.manager=allow"] if hasattr(java_runtime, "version") and java_runtime.version >= 17 else []
+    return ["-Djava.security.manager=allow"] if hasattr(java_runtime, "version") and java_runtime.version >= 17 and java_runtime.version < 24 else []

src/java/io/bazel/rulesscala/worker/Worker.java

@@ -54,14 +54,16 @@ public static void workerMain(String workerArgs[], Interface workerInterface) th
 
   /** The main loop for persistent worker processes */
   private static void persistentWorkerMain(Interface workerInterface) {
-    System.setSecurityManager(
-        new SecurityManager() {
-          @Override
-          public void checkPermission(Permission permission) {
-            Matcher matcher = exitPattern.matcher(permission.getName());
-            if (matcher.find()) throw new ExitTrapped(Integer.parseInt(matcher.group(1)));
-          }
-        });
+    if (Runtime.version().feature() < 24) {
+      System.setSecurityManager(
+              new SecurityManager() {
+                @Override
+                public void checkPermission(Permission permission) {
+                  Matcher matcher = exitPattern.matcher(permission.getName());
+                  if (matcher.find()) throw new ExitTrapped(Integer.parseInt(matcher.group(1)));
+                }
+              });
+    }
 
     InputStream stdin = System.in;
     PrintStream stdout = System.out;

src/java/io/bazel/rulesscala/worker/WorkerTest.java

@@ -216,7 +216,9 @@ public void testBufferWriteReadAndReset() throws Exception {
   public static void teardown() {
     // Persistent workers install a security manager. We need to
     // reset it here so that our own process can exit!
-    System.setSecurityManager(null);
+    if (Runtime.version().feature() < 24) {
+      System.setSecurityManager(null);
+    }
   }
 
   // Copied/modified from Bazel's MoreAsserts