Disallow duplicate method defs in proxy macro

Author: chrisrink10

src/basilisp/core.lpy

@@ -6964,7 +6964,6 @@
 
 ;; TODO: kwargs on supertypes
 ;; TODO: check interface/superclass method membership
-;; TODO: check if duplicate methods
 (defmacro proxy
   "Create a new proxy class instance.
 
@@ -7000,21 +6999,30 @@
   (let [formatted-single (fn [method-name [arg-vec & body]]
                            [(munge method-name)
                             (apply list 'fn method-name (vec (concat ['this] arg-vec)) body)])
-        formatted-multi (fn [method-name & arities]
-                          [(munge method-name)
-                           (apply list
-                                  'fn
-                                  method-name
-                                  (map (fn [[arg-vec & body]]
-                                         (apply list (vec (concat ['this] arg-vec)) body))
-                                       arities))])
-        methods      (mapcat (fn [[method-name & body]]
-                               (if (vector? (first body))
-                                 (formatted-single method-name body)
-                                 (apply formatted-multi method-name body)))
-                             fs)]
+        formatted-multi  (fn [method-name & arities]
+                           [(munge method-name)
+                            (apply list
+                                   'fn
+                                   method-name
+                                   (map (fn [[arg-vec & body]]
+                                          (apply list (vec (concat ['this] arg-vec)) body))
+                                        arities))])
+        methods          (map (fn [[method-name & body]]
+                                (if (vector? (first body))
+                                  (formatted-single method-name body)
+                                  (apply formatted-multi method-name body)))
+                              fs)
+        method-map       (reduce* (fn [m [method-name method]]
+                                    (if-let [existing-method (get m method-name)]
+                                      (throw
+                                       (ex-info "Cannot define proxy class with duplicate method"
+                                                {:method-name method-name
+                                                 :impls       [existing-method method]}))
+                                      (assoc m method-name method)))
+                                  {}
+                                  methods)]
     #_(println methods)
-    `((get-proxy-class ~@class-and-interfaces) ~(apply hash-map methods) ~@args)))
+    `((get-proxy-class ~@class-and-interfaces) ~method-map ~@args)))
 
 (defmacro proxy-super
   "Macro which expands to a call to the method named ``meth`` on the superclass

tests/basilisp/test_proxies.lpy

@@ -20,6 +20,9 @@
     (is (thrown? basilisp.lang.exception/ExceptionInfo
                  (construct-proxy python/object)))))
 
+(definterface Describable
+  (describe-me []))
+
 (definterface ToString
   (to-string [])
   (to-string [arg1])
@@ -33,6 +36,11 @@
   (to-string [this arg1 & rest] (str "rest" arg1 rest)))
 
 (deftest proxy-test
+  (testing "disallows duplicate method overrides"
+    (proxy [Describable] []
+      (describe-me [] "I'm a proxy")
+      (describe-me [] "Proxy")))
+
   (testing "multi-arity interface methods"
     (let [p (proxy [ConcreteToString] [1]
               (to-string