Fix "array to string conversion" in 3.5.0 (#1102)

LukeTowers · web-flow · commit 233c10688f4c · 2020-09-07T21:32:39.000+02:00
This commit broke the debugbar: 51c8ea3#diff-8a2d53e88e43b04de0cc4f64882d91feR63 since sprintf() uses multiple arguments, it doesn't accept an array of arguments.
diff --git a/src/DataFormatter/SimpleFormatter.php b/src/DataFormatter/SimpleFormatter.php
@@ -61,7 +61,7 @@ private function exportValue($value, $depth = 1, $deep = false)
 
             if ($deep) {
                 $args = [$indent, implode(sprintf(", \n%s", $indent), $a), str_repeat('  ', $depth - 1)];
-                return sprintf("[\n%s%s\n%s]", $args);
+                return sprintf("[\n%s%s\n%s]", ...$args);
             }
 
             $s = sprintf('[%s]', implode(', ', $a));

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ private function exportValue($value, $depth = 1, $deep = false)`
`61`	`61`
`62`	`62`	`if ($deep) {`
`63`	`63`	`$args = [$indent, implode(sprintf(", \n%s", $indent), $a), str_repeat(' ', $depth - 1)];`
`64`		`- return sprintf("[\n%s%s\n%s]", $args);`
	`64`	`+ return sprintf("[\n%s%s\n%s]", ...$args);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`$s = sprintf('[%s]', implode(', ', $a));`