fix(sha): return sha

Author: bahmutov

README.md

@@ -52,6 +52,8 @@ emptyGitHubCommit({
 })
 ```
 
+Resolves with an object with at least `sha` property of the new commit.
+
 Uses [http://mikedeboer.github.io/node-github](http://mikedeboer.github.io/node-github)
 to make API calls.
 

package.json

@@ -11,7 +11,7 @@
         "npm prune",
         "npm run deps",
         "npm test",
-        "git add src/*.js",
+        "git add src/*.js bin/*.js test/*.js",
         "npm run ban"
       ],
       "pre-push": [
@@ -60,31 +60,33 @@
     "deps": "deps-ok && dependency-check --no-dev .",
     "issues": "git-issues",
     "license": "license-checker --production --onlyunknown --csv",
-    "lint": "standard --verbose --fix src/*.js bin/*.js",
+    "lint": "standard --verbose --fix src/*.js bin/*.js test/*.js",
     "prelint": "npm run pretty",
     "pretest": "npm run lint",
-    "pretty": "prettier-standard 'src/*.js' 'bin/*.js'",
+    "pretty": "prettier-standard 'src/*.js' 'bin/*.js' 'test/*.js'",
     "secure": "nsp check",
     "size": "t=\"$(npm pack .)\"; wc -c \"${t}\"; tar tvf \"${t}\"; rm \"${t}\";",
     "test": "npm run unit",
-    "unit": "mocha src/*-spec.js",
+    "unit": "mocha src/*-spec.js test/*spec.js",
     "semantic-release": "semantic-release pre && npm publish && semantic-release post"
   },
   "release": {
     "analyzeCommits": "simple-commit-message"
   },
   "devDependencies": {
     "ban-sensitive-files": "1.9.0",
+    "check-more-types": "2.24.0",
     "dependency-check": "2.9.1",
     "deps-ok": "1.2.1",
     "git-issues": "1.3.1",
+    "lazy-ass": "1.6.0",
     "license-checker": "14.0.0",
     "mocha": "3.5.3",
     "nsp": "2.8.1",
     "pre-git": "3.15.3",
     "prettier-standard": "7.0.1",
-    "standard": "10.0.3",
-    "semantic-release": "^8.0.3"
+    "semantic-release": "^8.0.3",
+    "standard": "10.0.3"
   },
   "dependencies": {
     "debug": "3.1.0",

src/index.js

@@ -65,7 +65,7 @@ var createCommit = function (data) {
   })
 }
 
-var updateRefrence = function (data) {
+var updateReference = function (data) {
   console.log('updating reference')
   return new Promise((resolve, reject) => {
     data.github.gitdata.updateReference(
@@ -76,12 +76,12 @@ var updateRefrence = function (data) {
         sha: data.newCommitSha,
         force: data.forceUpdate
       },
-      (err, data) => {
+      (err, res) => {
         if (err) {
-          debug('updateRefrence', JSON.stringify(err, null, '  '))
+          debug('updateReference', JSON.stringify(err, null, '  '))
           return reject(err)
         }
-        return resolve(data)
+        return resolve(res.data)
       }
     )
   })
@@ -90,8 +90,8 @@ var updateRefrence = function (data) {
 function emptyGitHubCommit (opts) {
   opts = opts || {}
   if (!opts.owner || !opts.repo) {
-    console.error('missing owner or repo')
-    return ''
+    const e = new Error('missing owner or repo')
+    return Promise.reject(e)
   }
   var data = {}
   data.github = new GitHubApi()
@@ -114,8 +114,11 @@ function emptyGitHubCommit (opts) {
     getReferenceCommit(data)
       .then(getCommitData)
       .then(createCommit)
-      .then(updateRefrence)
-      .then(resolve)
+      .then(updateReference)
+      .then(data => {
+        console.log('new commit SHA', data.object.sha)
+        resolve({ sha: data.object.sha })
+      })
       .catch(error => reject(error))
   })
 }

test/spec.js

@@ -0,0 +1,29 @@
+'use strict'
+
+const la = require('lazy-ass')
+const is = require('check-more-types')
+const makeEmptyGithubCommit = require('..')
+
+/* eslint-env mocha */
+describe('make-empty-github-commit', () => {
+  const token =
+    process.env.TOKEN || process.env.GITHUB_TOKEN || process.env.GH_TOKEN
+
+  if (token) {
+    it('adds empty commit', function () {
+      this.timeout(10000)
+      if (!token) {
+        throw new Error('Cannot find TOKEN or GITHUB_TOKEN or GH_TOKEN')
+      }
+
+      return makeEmptyGithubCommit({
+        owner: 'bahmutov',
+        repo: 'test-make-empty-github-commit',
+        message: 'this is a test',
+        token: token
+      }).then(result => {
+        la(is.commitId(result.sha), 'expected to find sha in', result)
+      })
+    })
+  }
+})