Skip to content

Commit 29072d3

Browse files
committed
update commons-fileupload2-jakarta-servlet6 to 2.0.0-M4
This is to update dependency on commons-fileupload2-core from 2.0.0-M2 to 2.0.0-M4
1 parent cc0e127 commit 29072d3

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

aws-serverless-java-container-core/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
<dependency>
5555
<groupId>org.apache.commons</groupId>
5656
<artifactId>commons-fileupload2-jakarta-servlet6</artifactId>
57-
<version>2.0.0-M2</version>
57+
<version>2.0.0-M4</version>
5858
</dependency>
5959

6060
<dependency>

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpServletRequest.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ public Part getPart(String s)
493493
}
494494

495495
@SuppressFBWarnings({"FILE_UPLOAD_FILENAME", "WEAK_FILENAMEUTILS"})
496-
protected Map<String, List<Part>> getMultipartFormParametersMap() {
496+
protected Map<String, List<Part>> getMultipartFormParametersMap() throws RuntimeException {
497497
if (multipartFormParameters != null) {
498498
return multipartFormParameters;
499499
}
@@ -511,19 +511,20 @@ protected Map<String, List<Part>> getMultipartFormParametersMap() {
511511
List<DiskFileItem> items = upload.parseRequest(this);
512512
for (FileItem<DiskFileItem> item : items) {
513513
String fileName = FilenameUtils.getName(item.getName());
514-
AwsProxyRequestPart newPart = new AwsProxyRequestPart(item.get());
515-
newPart.setName(item.getFieldName());
516-
newPart.setSubmittedFileName(fileName);
517-
newPart.setContentType(item.getContentType());
518-
newPart.setSize(item.getSize());
519-
item.getHeaders().getHeaderNames().forEachRemaining(h -> {
520-
String headerValue = item.getHeaders().getHeader(h);
521-
if (headerValue != null) {
522-
newPart.addHeader(h, headerValue);
523-
}
524-
});
525-
526-
addPart(multipartFormParameters, item.getFieldName(), newPart);
514+
try {
515+
AwsProxyRequestPart newPart = new AwsProxyRequestPart(item.get());
516+
newPart.setName(item.getFieldName());
517+
newPart.setSubmittedFileName(fileName);
518+
newPart.setContentType(item.getContentType());
519+
newPart.setSize(item.getSize());
520+
item.getHeaders().getHeaderNames().forEachRemaining(h -> {
521+
newPart.addHeader(h, item.getHeaders().getHeader(h));
522+
});
523+
addPart(multipartFormParameters, item.getFieldName(), newPart);
524+
} catch (Exception e) {
525+
log.error("Encounter issue adding form multipart", e);
526+
throw new RuntimeException(e);
527+
}
527528
}
528529
} catch (FileUploadException e) {
529530
Timer.stop("SERVLET_REQUEST_GET_MULTIPART_PARAMS");

0 commit comments

Comments
 (0)