fix: error when instance_count>1 in remote_function #3838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohangujarathi
requested review from
mufaddal-rohawala
and removed request for
a team
rohangujarathi
force-pushed
the
remote_function_fix
branch
from
3d5c5b2 to
8a84034
Compare
dpatro
reviewed
May 5, 2023
| methods that are not available via PyPI or conda. Default value is ``False``. | ||
| instance_count (int): The number of instances to use. Defaults to 1. | ||
| Remote function do not support instance_count > 1 |
Contributor
There was a problem hiding this comment.
suggestion framing the statement as NOTE: Remote function does not support . . .
rohangujarathi
force-pushed
the
remote_function_fix
branch
from
8a84034 to
017c094
Compare
dpatro
approved these changes
May 5, 2023
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nmadan
approved these changes
May 5, 2023
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3838 +/- ##
==========================================
- Coverage 89.88% 88.97% -0.91%
==========================================
Files 1060 247 -813
Lines 101208 25161 -76047
==========================================
- Hits 90973 22388 -68585
+ Misses 10235 2773 -7462
|
Collaborator
claytonparnell
left a comment
claytonparnell
left a comment
There was a problem hiding this comment.
/bot run slow-tests
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
knikure
approved these changes
May 8, 2023
knikure
pushed a commit
to knikure/sagemaker-python-sdk
that referenced
this pull request
May 8, 2023
Co-authored-by: Rohan Gujarathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.