Skip to content

feature: Update instance types for integ test #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2022
Merged

feature: Update instance types for integ test #2881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eec99c1
upate instance types for integ test
jeniyat Jan 28, 2022
7db3cf9
update instance types for integ test
jeniyat Jan 28, 2022
b53952e
removed comments, extra new-lines
jeniyat Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def cpu_instance_type(sagemaker_session, request):

@pytest.fixture(scope="module")
def gpu_instance_type(request):
return "ml.p2.xlarge"
return "ml.p3.2xlarge"


@pytest.fixture(scope="session")
Expand Down Expand Up @@ -408,7 +408,7 @@ def pytest_generate_tests(metafunc):
region in tests.integ.HOSTING_NO_P2_REGIONS
or region in tests.integ.TRAINING_NO_P2_REGIONS
):
params.append("ml.p2.xlarge")
params.append("ml.p3.2xlarge")
metafunc.parametrize("instance_type", params, scope="session")
Copy link
Contributor

@shreyapandit shreyapandit Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

@jeniyat jeniyat Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the current revision.


_generate_all_framework_version_fixtures(metafunc)
Expand Down
2 changes: 1 addition & 1 deletion tests/integ/test_horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_hvd_gpu(
sagemaker_session,
tensorflow_training_latest_version,
tensorflow_training_latest_py_version,
"ml.p2.xlarge",
"ml.p3.2xlarge",
tmpdir,
)

Expand Down