-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Hyperparameter validation #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shreyapandit
merged 11 commits into
aws:master-jumpstart
from
evakravi:feat/hyperparameter-validation
Jan 25, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f4b0536
feat: hyperparameter validation
evakravi 8f4aecf
change: improve jumpstart hyperparam validation logic
evakravi c917ad8
Merge branch 'master-jumpstart' into feat/hyperparameter-validation
evakravi dd26117
change: add return typing
evakravi 063cdc7
change: add js unit tests for hyperparam validation for min/max/exclu…
evakravi c6eb14d
fix: jumpstart docstring
evakravi 76271ea
Merge remote-tracking branch 'upstream/master-jumpstart' into feat/hy…
evakravi 8a95942
Merge remote-tracking branch 'upstream/master-jumpstart' into feat/hy…
evakravi 617adc1
fix: update jumpstart docstring
evakravi aa13bcf
Merge branch 'master-jumpstart' into feat/hyperparameter-validation
shreyapandit 8a35894
fix: entry point variable name
evakravi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"). You | ||
| # may not use this file except in compliance with the License. A copy of | ||
| # the License is located at | ||
| # | ||
| # http://aws.amazon.com/apache2.0/ | ||
| # | ||
| # or in the "license" file accompanying this file. This file is | ||
| # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
| # ANY KIND, either express or implied. See the License for the specific | ||
| # language governing permissions and limitations under the License. | ||
| """This module stores enums related to SageMaker JumpStart.""" | ||
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| from enum import Enum | ||
|
|
||
|
|
||
| class ModelFramework(str, Enum): | ||
| """Enum class for JumpStart model framework. | ||
|
|
||
| The ML framework as referenced in the prefix of the model ID. | ||
| This value does not necessarily correspond to the container name. | ||
| """ | ||
|
|
||
| PYTORCH = "pytorch" | ||
| TENSORFLOW = "tensorflow" | ||
| MXNET = "mxnet" | ||
| HUGGINGFACE = "huggingface" | ||
| LIGHTGBM = "lightgbm" | ||
| CATBOOST = "catboost" | ||
| XGBOOST = "xgboost" | ||
| SKLEARN = "sklearn" | ||
|
|
||
|
|
||
| class VariableScope(str, Enum): | ||
| """Possible value of the ``scope`` attribute for a hyperparameter or environment variable. | ||
|
|
||
| Used for hosting environment variables and training hyperparameters. | ||
| """ | ||
|
|
||
| CONTAINER = "container" | ||
| ALGORITHM = "algorithm" | ||
|
|
||
|
|
||
| class JumpStartScriptScope(str, Enum): | ||
| """Enum class for JumpStart script scopes.""" | ||
|
|
||
| INFERENCE = "inference" | ||
| TRAINING = "training" | ||
|
|
||
|
|
||
| class HyperparameterValidationMode(str, Enum): | ||
| """Possible modes for validating hyperparameters.""" | ||
|
|
||
| VALIDATE_PROVIDED = "validate_provided" | ||
| VALIDATE_ALGORITHM = "validate_algorithm" | ||
| VALIDATE_ALL = "validate_all" | ||
|
|
||
|
|
||
| class VariableTypes(str, Enum): | ||
| """Possible types for hyperparameters and environment variables.""" | ||
|
|
||
| TEXT = "text" | ||
| INT = "int" | ||
| FLOAT = "float" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we add a |
||
| BOOL = "bool" | ||
|
|
||
|
|
||
| class JumpStartTag(str, Enum): | ||
| """Enum class for tag keys to apply to JumpStart models.""" | ||
|
|
||
| INFERENCE_MODEL_URI = "aws-jumpstart-inference-model-uri" | ||
| INFERENCE_SCRIPT_URI = "aws-jumpstart-inference-script-uri" | ||
| TRAINING_MODEL_URI = "aws-jumpstart-training-model-uri" | ||
| TRAINING_SCRIPT_URI = "aws-jumpstart-training-script-uri" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a
Raises:section in the docstring please.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: also add
ValueErrorin Raises docsting.