Skip to content

Conversation

@laurenyu
Copy link
Contributor

@laurenyu laurenyu commented Jan 14, 2020

Issue #, if available:

Description of changes:
SageMaker Automatic Model Tuning adds a private hyperparameter to all of its training jobs. This can cause an issue when attaching to a training job with the hyperparameter:

ValueError: Invalid hyperparameter: _tuning_objective_metric is not supported by <algorithm>

I tested this with KMeans, and the private hyperparameter is not included after attaching, so I've gone for the same approach with AlgorithmEstimator.

Testing done:
Tested manually by adapting the code from this notebook to create a training job to try attaching to.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@laurenyu laurenyu merged commit 479c9c4 into aws:master Jan 15, 2020
@laurenyu laurenyu deleted the marketplace-attach branch January 15, 2020 01:51
benieric pushed a commit to benieric/sagemaker-python-sdk that referenced this pull request Jul 22, 2025
* feat: Queue and QueuedJob implementation for AWS Batch Service (aws#991)

* fix: Update Batch endpoint; Function renaming (aws#1230)

Co-authored-by: Jenna Zhao <[email protected]>

* chore: minor formatting

---------

Co-authored-by: haoxinwa <[email protected]>
Co-authored-by: JennaZhao <[email protected]>
Co-authored-by: Jenna Zhao <[email protected]>
Co-authored-by: Gregory Katkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants