From 354ac79de458d17956787d4a6ae7cb3d0321dc4a Mon Sep 17 00:00:00 2001 From: Lauren Yu <6631887+laurenyu@users.noreply.github.com> Date: Wed, 8 Jan 2020 13:48:21 -0800 Subject: [PATCH 1/2] change: add another test-related item to the PR checklist --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ace9c72f15..388728d468 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,9 +10,11 @@ _Put an `x` in the boxes that apply. You can also fill these out after creating - [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc - [ ] I used the commit message format described in [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#committing-your-change) -- [ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate) -- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate) -- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate) - [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate) +- [ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate) +- Tests + - [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate) + - [ ] I have checked that my tests are not configured for a specific region or account (if appropriate) + - [ ] I have used [`unique_name_from_base`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/utils.py#L77) to create resource names in integ tests (if appropriate) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. From 0769f7ed5b80973d47bfa16cbb66d1062d749a64 Mon Sep 17 00:00:00 2001 From: Lauren Yu <6631887+laurenyu@users.noreply.github.com> Date: Wed, 8 Jan 2020 13:56:49 -0800 Subject: [PATCH 2/2] add sections --- .github/PULL_REQUEST_TEMPLATE.md | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 388728d468..011e5166ab 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,13 +8,17 @@ _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._ +#### General + - [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc - [ ] I used the commit message format described in [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md#committing-your-change) -- [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate) - [ ] I have used the regional endpoint when creating S3 and/or STS clients (if appropriate) -- Tests - - [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate) - - [ ] I have checked that my tests are not configured for a specific region or account (if appropriate) - - [ ] I have used [`unique_name_from_base`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/utils.py#L77) to create resource names in integ tests (if appropriate) +- [ ] I have updated any necessary documentation, including [READMEs](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) and [API docs](https://github.com/aws/sagemaker-python-sdk/tree/master/doc) (if appropriate) + +#### Tests + +- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate) +- [ ] I have checked that my tests are not configured for a specific region or account (if appropriate) +- [ ] I have used [`unique_name_from_base`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/utils.py#L77) to create resource names in integ tests (if appropriate) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.