From 84506b489a6a2a9f88cbd86db75453e7ddc9679f Mon Sep 17 00:00:00 2001 From: Lauren Yu <6631887+laurenyu@users.noreply.github.com> Date: Mon, 9 Sep 2019 15:04:27 -0700 Subject: [PATCH] fix: add https to regional STS endpoint --- src/sagemaker/utils.py | 2 +- tests/unit/test_utils.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sagemaker/utils.py b/src/sagemaker/utils.py index 2fe9c33a96..f36379bafe 100644 --- a/src/sagemaker/utils.py +++ b/src/sagemaker/utils.py @@ -553,7 +553,7 @@ def sts_regional_endpoint(region): Returns: str: AWS STS regional endpoint """ - return "sts.{}.amazonaws.com".format(region) + return "https://sts.{}.amazonaws.com".format(region) class DeferredError(object): diff --git a/tests/unit/test_utils.py b/tests/unit/test_utils.py index f94142614f..cd1d6caa0e 100644 --- a/tests/unit/test_utils.py +++ b/tests/unit/test_utils.py @@ -22,6 +22,7 @@ import time from boto3 import exceptions +import botocore import pytest from mock import call, patch, Mock, MagicMock @@ -564,4 +565,5 @@ def walk(): def test_sts_regional_endpoint(): endpoint = sagemaker.utils.sts_regional_endpoint("us-west-2") - assert endpoint == "sts.us-west-2.amazonaws.com" + assert endpoint == "https://sts.us-west-2.amazonaws.com" + assert botocore.utils.is_valid_endpoint_url(endpoint)